[dpdk-test-report] |WARNING| pw73631 [PATCH v3 2/2] Add l2reflect measurement application

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jul 9 11:28:20 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/73631

_coding style issues_


WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#162: FILE: app/l2reflect/l2reflect.h:45:
+int l2reflect_hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#163: FILE: app/l2reflect/l2reflect.h:46:
+atomic_int l2reflect_output_hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#334: FILE: app/l2reflect/main.c:149:
+	hist_filename = NULL;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#335: FILE: app/l2reflect/main.c:150:
+	l2reflect_output_hist = 0;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#375: FILE: app/l2reflect/main.c:190:
+			l2reflect_hist = 1;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#376: FILE: app/l2reflect/main.c:191:
+			hist_bucket_usec = strtoul(optarg, NULL, 10);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#383: FILE: app/l2reflect/main.c:198:
+			hist_filename = strndup(optarg, 128);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#398: FILE: app/l2reflect/main.c:213:
+	if (hist_filename && !l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#398: FILE: app/l2reflect/main.c:213:
+	if (hist_filename && !l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#683: FILE: app/l2reflect/main.c:498:
+		if (l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#685: FILE: app/l2reflect/main.c:500:
+				MIN(diff / (hist_bucket_usec * 1000),

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#686: FILE: app/l2reflect/main.c:501:
+				    HIST_CAP_BUCKET);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#687: FILE: app/l2reflect/main.c:502:
+			record.hist[bucket]++;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#882: FILE: app/l2reflect/main.c:697:
+		l2reflect_output_hist = 1;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1007: FILE: app/l2reflect/main.c:822:
+	 * in quiet mode the master executes the main packet loop

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#1008: FILE: app/l2reflect/main.c:823:
+	 * otherwise the one slave does it and the master prints stats

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1008: FILE: app/l2reflect/main.c:823:
+	 * otherwise the one slave does it and the master prints stats

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#1019: FILE: app/l2reflect/main.c:834:
+		/* the slave reflects the packets */

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#1020: FILE: app/l2reflect/main.c:835:
+		RTE_LCORE_FOREACH_SLAVE(lcore_id)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1026: FILE: app/l2reflect/main.c:841:
+		/* the master prints the stats */

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1033: FILE: app/l2reflect/main.c:848:
+	if (l2reflect_hist)

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1110: FILE: app/l2reflect/stats.c:34:
+	if (l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1111: FILE: app/l2reflect/stats.c:35:
+		if (!record.hist_size) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1112: FILE: app/l2reflect/stats.c:36:
+			record.hist =

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1113: FILE: app/l2reflect/stats.c:37:
+				calloc(HIST_NUM_BUCKETS, sizeof(uint64_t));

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1114: FILE: app/l2reflect/stats.c:38:
+			record.hist_size = HIST_NUM_BUCKETS;

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1114: FILE: app/l2reflect/stats.c:38:
+			record.hist_size = HIST_NUM_BUCKETS;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1116: FILE: app/l2reflect/stats.c:40:
+			memset(record.hist, 0,

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1117: FILE: app/l2reflect/stats.c:41:
+			       record.hist_size * sizeof(uint64_t));

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1125: FILE: app/l2reflect/stats.c:49:
+	if (l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1126: FILE: app/l2reflect/stats.c:50:
+		free(record.hist);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1127: FILE: app/l2reflect/stats.c:51:
+		record.hist = NULL;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1128: FILE: app/l2reflect/stats.c:52:
+		record.hist_size = 0;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1137: FILE: app/l2reflect/stats.c:61:
+	if (hist_filename)

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1138: FILE: app/l2reflect/stats.c:62:
+		fd = fopen(hist_filename, "w");

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1142: FILE: app/l2reflect/stats.c:66:
+	if (hist_filename)

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1219: FILE: app/l2reflect/stats.c:143:
+		if (l2reflect_hist && l2reflect_output_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1219: FILE: app/l2reflect/stats.c:143:
+		if (l2reflect_hist && l2reflect_output_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1221: FILE: app/l2reflect/stats.c:145:
+			l2reflect_output_hist = 0;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1236: FILE: app/l2reflect/stats.c:160:
+	cJSON *hist0, *cpu0, *all_cpus, *output;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1243: FILE: app/l2reflect/stats.c:167:
+	hist0 = cJSON_CreateObject();

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1244: FILE: app/l2reflect/stats.c:168:
+	for (i = 0; i < record->hist_size; ++i) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1246: FILE: app/l2reflect/stats.c:170:
+		if (record->hist[i] != 0) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1247: FILE: app/l2reflect/stats.c:171:
+			snprintf(key, 8, "%u", i * hist_bucket_usec);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1248: FILE: app/l2reflect/stats.c:172:
+			cJSON_AddNumberToObject(hist0, key, record->hist[i]);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1248: FILE: app/l2reflect/stats.c:172:
+			cJSON_AddNumberToObject(hist0, key, record->hist[i]);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1254: FILE: app/l2reflect/stats.c:178:
+	cJSON_AddItemToObject(cpu0, "histogram", hist0);

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1303: FILE: app/l2reflect/stats.h:20:
+#define HIST_NUM_BUCKETS 128

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1304: FILE: app/l2reflect/stats.h:21:
+#define HIST_CAP_BUCKET (HIST_NUM_BUCKETS - 1)

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1304: FILE: app/l2reflect/stats.h:21:
+#define HIST_CAP_BUCKET (HIST_NUM_BUCKETS - 1)

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1307: FILE: app/l2reflect/stats.h:24:
+unsigned int hist_bucket_usec;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1316: FILE: app/l2reflect/stats.h:33:
+	unsigned int hist_size;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1318: FILE: app/l2reflect/stats.h:35:
+	uint64_t *hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1322: FILE: app/l2reflect/stats.h:39:
+char *hist_filename;

total: 0 errors, 54 warnings, 1237 lines checked


More information about the test-report mailing list