[dpdk-test-report] |WARNING| pw74124 [PATCH v4 2/2] Add l2reflect measurement application

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Jul 15 17:55:34 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/74124

_coding style issues_


WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#162: FILE: app/l2reflect/l2reflect.h:45:
+extern int l2reflect_hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#163: FILE: app/l2reflect/l2reflect.h:46:
+extern atomic_int l2reflect_output_hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#268: FILE: app/l2reflect/main.c:83:
+int l2reflect_hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#269: FILE: app/l2reflect/main.c:84:
+atomic_int l2reflect_output_hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#347: FILE: app/l2reflect/main.c:162:
+	hist_filename = NULL;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#348: FILE: app/l2reflect/main.c:163:
+	l2reflect_output_hist = 0;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#388: FILE: app/l2reflect/main.c:203:
+			l2reflect_hist = 1;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#389: FILE: app/l2reflect/main.c:204:
+			hist_bucket_usec = strtoul(optarg, NULL, 10);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#396: FILE: app/l2reflect/main.c:211:
+			hist_filename = strndup(optarg, 128);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#411: FILE: app/l2reflect/main.c:226:
+	if (hist_filename && !l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#411: FILE: app/l2reflect/main.c:226:
+	if (hist_filename && !l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#696: FILE: app/l2reflect/main.c:511:
+		if (l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#698: FILE: app/l2reflect/main.c:513:
+				MIN(diff / (hist_bucket_usec * 1000),

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#699: FILE: app/l2reflect/main.c:514:
+				    HIST_CAP_BUCKET);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#700: FILE: app/l2reflect/main.c:515:
+			record.hist[bucket]++;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#895: FILE: app/l2reflect/main.c:710:
+		l2reflect_output_hist = 1;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1020: FILE: app/l2reflect/main.c:835:
+	 * in quiet mode the master executes the main packet loop

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#1021: FILE: app/l2reflect/main.c:836:
+	 * otherwise the one slave does it and the master prints stats

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1021: FILE: app/l2reflect/main.c:836:
+	 * otherwise the one slave does it and the master prints stats

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#1034: FILE: app/l2reflect/main.c:849:
+		/* the slave reflects the packets */

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#1035: FILE: app/l2reflect/main.c:850:
+		RTE_LCORE_FOREACH_SLAVE(lcore_id)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1041: FILE: app/l2reflect/main.c:856:
+		/* the master prints the stats */

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1048: FILE: app/l2reflect/main.c:863:
+	if (l2reflect_hist)

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1120: FILE: app/l2reflect/stats.c:26:
+unsigned int hist_bucket_usec;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1122: FILE: app/l2reflect/stats.c:28:
+char *hist_filename;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1132: FILE: app/l2reflect/stats.c:38:
+	if (l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1133: FILE: app/l2reflect/stats.c:39:
+		if (!record.hist_size) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1134: FILE: app/l2reflect/stats.c:40:
+			record.hist =

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1135: FILE: app/l2reflect/stats.c:41:
+				calloc(HIST_NUM_BUCKETS, sizeof(uint64_t));

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1136: FILE: app/l2reflect/stats.c:42:
+			record.hist_size = HIST_NUM_BUCKETS;

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1136: FILE: app/l2reflect/stats.c:42:
+			record.hist_size = HIST_NUM_BUCKETS;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1138: FILE: app/l2reflect/stats.c:44:
+			memset(record.hist, 0,

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1139: FILE: app/l2reflect/stats.c:45:
+			       record.hist_size * sizeof(uint64_t));

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1147: FILE: app/l2reflect/stats.c:53:
+	if (l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1148: FILE: app/l2reflect/stats.c:54:
+		free(record.hist);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1149: FILE: app/l2reflect/stats.c:55:
+		record.hist = NULL;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1150: FILE: app/l2reflect/stats.c:56:
+		record.hist_size = 0;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1159: FILE: app/l2reflect/stats.c:65:
+	if (hist_filename)

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1160: FILE: app/l2reflect/stats.c:66:
+		fd = fopen(hist_filename, "w");

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1164: FILE: app/l2reflect/stats.c:70:
+	if (hist_filename)

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1241: FILE: app/l2reflect/stats.c:147:
+		if (l2reflect_hist && l2reflect_output_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1241: FILE: app/l2reflect/stats.c:147:
+		if (l2reflect_hist && l2reflect_output_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1243: FILE: app/l2reflect/stats.c:149:
+			l2reflect_output_hist = 0;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1258: FILE: app/l2reflect/stats.c:164:
+	cJSON *hist0, *cpu0, *all_cpus, *output;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1265: FILE: app/l2reflect/stats.c:171:
+	hist0 = cJSON_CreateObject();

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1266: FILE: app/l2reflect/stats.c:172:
+	for (i = 0; i < record->hist_size; ++i) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1268: FILE: app/l2reflect/stats.c:174:
+		if (record->hist[i] != 0) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1269: FILE: app/l2reflect/stats.c:175:
+			snprintf(key, 8, "%u", i * hist_bucket_usec);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1270: FILE: app/l2reflect/stats.c:176:
+			cJSON_AddNumberToObject(hist0, key, record->hist[i]);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1270: FILE: app/l2reflect/stats.c:176:
+			cJSON_AddNumberToObject(hist0, key, record->hist[i]);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1276: FILE: app/l2reflect/stats.c:182:
+	cJSON_AddItemToObject(cpu0, "histogram", hist0);

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1325: FILE: app/l2reflect/stats.h:20:
+#define HIST_NUM_BUCKETS 128

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1326: FILE: app/l2reflect/stats.h:21:
+#define HIST_CAP_BUCKET (HIST_NUM_BUCKETS - 1)

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1326: FILE: app/l2reflect/stats.h:21:
+#define HIST_CAP_BUCKET (HIST_NUM_BUCKETS - 1)

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1335: FILE: app/l2reflect/stats.h:30:
+	unsigned int hist_size;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1337: FILE: app/l2reflect/stats.h:32:
+	uint64_t *hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1341: FILE: app/l2reflect/stats.h:36:
+extern unsigned int hist_bucket_usec;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1343: FILE: app/l2reflect/stats.h:38:
+extern char *hist_filename;

total: 0 errors, 58 warnings, 1258 lines checked


More information about the test-report mailing list