[dpdk-test-report] |WARNING| pw74149 [PATCH v5 6/9] eal: replace pci-whitelist/pci-blacklist options

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jul 16 01:05:11 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/74149

_coding style issues_


WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#65: 
Subject: [dpdk-dev] [PATCH v5 6/9] eal: replace pci-whitelist/pci-blacklist

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#65: 
Subject: [dpdk-dev] [PATCH v5 6/9] eal: replace pci-whitelist/pci-blacklist

WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#81: 
Replace "pci-whitelist" with "include"

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#82: 
and "pci-blacklist" with pci-exclude.

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#126: FILE: lib/librte_eal/common/eal_common_options.c:92:
+^I{OPT_DEV_EXCLUDE, ^I1, NULL, OPT_DEV_EXCLUDE_NUM^I  },$

WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#137: FILE: lib/librte_eal/common/eal_common_options.c:109:
+	{OPT_PCI_BLACKLIST,     1, NULL, OPT_PCI_BLACKLIST_NUM    },

WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#137: FILE: lib/librte_eal/common/eal_common_options.c:109:
+	{OPT_PCI_BLACKLIST,     1, NULL, OPT_PCI_BLACKLIST_NUM    },

WARNING:TYPO_SPELLING: 'WHITELIST' may be misspelled - perhaps 'ALLOWLIST'?
#138: FILE: lib/librte_eal/common/eal_common_options.c:110:
+	{OPT_PCI_WHITELIST,     1, NULL, OPT_PCI_WHITELIST_NUM    },

WARNING:TYPO_SPELLING: 'WHITELIST' may be misspelled - perhaps 'ALLOWLIST'?
#138: FILE: lib/librte_eal/common/eal_common_options.c:110:
+	{OPT_PCI_WHITELIST,     1, NULL, OPT_PCI_WHITELIST_NUM    },

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#159: FILE: lib/librte_eal/common/eal_common_options.c:1430:
+			"Option -b, --blacklist is deprecated, use -x, --exclude option instead
");

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#160: FILE: lib/librte_eal/common/eal_common_options.c:1431:
+		/* fallthrough */

WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#179: FILE: lib/librte_eal/common/eal_common_options.c:1445:
+			"Option -w, --whitelist is deprecated, use -i, --include option instead
");

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#180: FILE: lib/librte_eal/common/eal_common_options.c:1446:
+		/* fallthrough */

WARNING:LONG_LINE: line over 100 characters
#227: FILE: lib/librte_eal/common/eal_common_options.c:1953:
+	       "                      [NOTE: " OPT_DEV_INCLUDE " cannot be used with "OPT_DEV_EXCLUDE" option]
"

total: 0 errors, 14 warnings, 140 lines checked


More information about the test-report mailing list