[dpdk-test-report] |WARNING| pw71423 [PATCH 31/50] net/bnxt: add support for EEM System memory

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jun 12 15:48:30 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/71423

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#685: FILE: drivers/net/bnxt/tf_core/tf_em_common.c:461:
+			    "table: %d data-sz: %016" PRIu64 " page-sz: %u
",

WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#702: FILE: drivers/net/bnxt/tf_core/tf_em_common.c:478:
+		    "EEM: lvls: %d sz: %016" PRIu64 " pgs: %016" PRIu64 \

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#870: FILE: drivers/net/bnxt/tf_core/tf_em_common.c:646:
+	tbl_scope_cb->em_ctx_info[TF_DIR_RX].em_tables[TF_RECORD_TABLE].num_entries
+		= parms->rx_num_flows_in_k * TF_KILOBYTE;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#872: FILE: drivers/net/bnxt/tf_core/tf_em_common.c:648:
+	tbl_scope_cb->em_ctx_info[TF_DIR_RX].em_tables[TF_RECORD_TABLE].entry_size
+		= parms->rx_max_action_entry_sz_in_bits / 8;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#875: FILE: drivers/net/bnxt/tf_core/tf_em_common.c:651:
+	tbl_scope_cb->em_ctx_info[TF_DIR_RX].em_tables[TF_EFC_TABLE].num_entries
+		= 0;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#889: FILE: drivers/net/bnxt/tf_core/tf_em_common.c:665:
+	tbl_scope_cb->em_ctx_info[TF_DIR_TX].em_tables[TF_RECORD_TABLE].num_entries
+		= parms->tx_num_flows_in_k * TF_KILOBYTE;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#891: FILE: drivers/net/bnxt/tf_core/tf_em_common.c:667:
+	tbl_scope_cb->em_ctx_info[TF_DIR_TX].em_tables[TF_RECORD_TABLE].entry_size
+		= parms->tx_max_action_entry_sz_in_bits / 8;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#894: FILE: drivers/net/bnxt/tf_core/tf_em_common.c:670:
+	tbl_scope_cb->em_ctx_info[TF_DIR_TX].em_tables[TF_EFC_TABLE].num_entries
+		= 0;

WARNING:LONG_LINE: line over 90 characters
#930: FILE: drivers/net/bnxt/tf_core/tf_em_common.c:706:
+	mask = tf_em_get_key_mask(tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY0_TABLE].num_entries);

WARNING:LONG_LINE: line over 90 characters
#968: FILE: drivers/net/bnxt/tf_core/tf_em_common.c:743:
+		(uint8_t *)&tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY0_TABLE];

WARNING:LONG_LINE: line over 90 characters
#985: FILE: drivers/net/bnxt/tf_core/tf_em_common.c:760:
+			(uint8_t *)&tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY1_TABLE];

WARNING:LONG_LINE: line over 90 characters
#1188: FILE: drivers/net/bnxt/tf_core/tf_em_common.c:1024:
+		(uint8_t *)&tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_RECORD_TABLE];

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#2109: FILE: drivers/net/bnxt/tf_core/tf_em_system.c:85:
+extern struct tf_tbl_scope_cb tbl_scopes[TF_NUM_TBL_SCOPE];

WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#2414: FILE: drivers/net/bnxt/tf_core/tf_em_system.c:340:
+				  tbl_scope_cb->em_ctx_info[TF_DIR_RX].\

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#2508: FILE: drivers/net/bnxt/tf_core/tf_em_system.c:432:
+		for (i = TF_KEY0_TABLE; i < TF_MAX_TABLE; i++) {
+

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#2511: FILE: drivers/net/bnxt/tf_core/tf_em_system.c:435:
+				/*TFP_DRV_LOG(WARNING,
+					    "Not support EFC table in WH+
");*/

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#2511: FILE: drivers/net/bnxt/tf_core/tf_em_system.c:435:
+					    "Not support EFC table in WH+
");*/

total: 0 errors, 9 warnings, 8 checks, 2460 lines checked


More information about the test-report mailing list