[dpdk-test-report] |WARNING| pw66351 [PATCH 1/4] lib: introduce IF Proxy library

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 6 17:42:02 CET 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66351

_coding style issues_


WARNING:MISSING_BREAK: Possible switch case/default not preceded by break or fallthrough comment
#213: FILE: lib/librte_eal/linux/eal/eal_interrupts.c:902:
+		case RTE_INTR_HANDLE_NETLINK:

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#290: FILE: lib/librte_if_proxy/if_proxy_common.c:32:
+	int (*f_ptr)(void*);   /* type for normal event notification */

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void*' should also have an identifier name
#290: FILE: lib/librte_if_proxy/if_proxy_common.c:32:
+	int (*f_ptr)(void*);   /* type for normal event notification */

WARNING:TYPO_SPELLING: 'refered' may be misspelled - perhaps 'referred'?
#828: FILE: lib/librte_if_proxy/if_proxy_priv.h:70:
+ * particular the proxy passed as an argument) since they might still be refered

WARNING:TYPO_SPELLING: 'calle' may be misspelled - perhaps 'called'?
#842: FILE: lib/librte_if_proxy/if_proxy_priv.h:84:
+ *     listening service this function is calle with 0 as an argument.  In that

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#986: FILE: lib/librte_if_proxy/linux/if_proxy.c:115:
+	    (h->nlmsg_seq >> 8) != (unsigned)ifi->ifi_index)

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#1123: FILE: lib/librte_if_proxy/linux/if_proxy.c:252:
+		int if_index = *((int32_t*)RTA_DATA(attrs[RTA_OIF]));

ERROR:CODE_INDENT: code indent should use tabs where possible
#1143: FILE: lib/librte_if_proxy/linux/if_proxy.c:272:
+^I^I                    : RTE_IFPX_ROUTE_ADD;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#1145: FILE: lib/librte_if_proxy/linux/if_proxy.c:274:
+^I^I                RTE_IPV4(ip[0], ip[1], ip[2], ip[3]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#1148: FILE: lib/librte_if_proxy/linux/if_proxy.c:277:
+^I^I                    : RTE_IFPX_ROUTE6_ADD;$

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#1176: FILE: lib/librte_if_proxy/linux/if_proxy.c:305:
+#define NDA_RTA(r) ((const struct rtattr*)(((const char*)(r)) + \

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#1176: FILE: lib/librte_if_proxy/linux/if_proxy.c:305:
+#define NDA_RTA(r) ((const struct rtattr*)(((const char*)(r)) + \

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1206: FILE: lib/librte_if_proxy/linux/if_proxy.c:335:
+		if (px->info.if_index == (unsigned)n->ndm_ifindex)

ERROR:CODE_INDENT: code indent should use tabs where possible
#1219: FILE: lib/librte_if_proxy/linux/if_proxy.c:348:
+^I^I                    : RTE_IFPX_NEIGH_ADD;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#1221: FILE: lib/librte_if_proxy/linux/if_proxy.c:350:
+^I^I                RTE_IPV4(ip[0], ip[1], ip[2], ip[3]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#1224: FILE: lib/librte_if_proxy/linux/if_proxy.c:353:
+^I^I                    : RTE_IFPX_NEIGH6_ADD;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#1229: FILE: lib/librte_if_proxy/linux/if_proxy.c:358:
+^I^I                    &ev.neigh_change.mac);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#1401: FILE: lib/librte_if_proxy/linux/if_proxy.c:530:
+^I^I                                  if_proxy_intr_callback, NULL);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#1598: FILE: lib/librte_if_proxy/rte_if_proxy.h:144:
+                               * signaled when initial network configuration$

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1598: FILE: lib/librte_if_proxy/rte_if_proxy.h:144:
+	RTE_IFPX_CFG_DONE,    /**< This event is a lib specific event - it is
+                               * signaled when initial network configuration

total: 13 errors, 7 warnings, 1860 lines checked


More information about the test-report mailing list