[dpdk-test-report] |WARNING| pw69714 [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

checkpatch at dpdk.org checkpatch at dpdk.org
Mon May 4 19:28:25 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/69714

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#63: 
When fragmenting ipv4 packet, the data offset should be calculated through the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).

ERROR:CODE_INDENT: code indent should use tabs where possible
#85: FILE: lib/librte_ip_frag/rte_ipv4_fragmentation.c:27:
+        uint16_t len, uint16_t fofs, uint16_t dofs, uint32_t mf)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#85: FILE: lib/librte_ip_frag/rte_ipv4_fragmentation.c:27:
+        uint16_t len, uint16_t fofs, uint16_t dofs, uint32_t mf)$

WARNING:LONG_LINE: line over 90 characters
#106: FILE: lib/librte_ip_frag/rte_ipv4_fragmentation.c:90:
+	header_len = (in_hdr->version_ihl & RTE_IPV4_HDR_IHL_MASK) * RTE_IPV4_IHL_MULTIPLIER;

total: 1 errors, 3 warnings, 84 lines checked


More information about the test-report mailing list