[dpdk-test-report] |WARNING| pw80544 [PATCH 23/36] net/sfc: support TSO for EF100 native datapath

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Oct 13 15:59:43 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/80544

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'header_len > txq->tso_max_header_len'
#213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123:
+	if (unlikely((header_len > txq->tso_max_header_len) |
+		     (nb_payload_descs > txq->tso_max_nb_payload_descs) |
+		     (payload_len > txq->tso_max_payload_len) |
+		     (payload_len > mss_conformant_max_payload_len) |
+		     (m->pkt_len == header_len)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_payload_descs > txq->tso_max_nb_payload_descs'
#213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123:
+	if (unlikely((header_len > txq->tso_max_header_len) |
+		     (nb_payload_descs > txq->tso_max_nb_payload_descs) |
+		     (payload_len > txq->tso_max_payload_len) |
+		     (payload_len > mss_conformant_max_payload_len) |
+		     (m->pkt_len == header_len)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'payload_len > txq->tso_max_payload_len'
#213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123:
+	if (unlikely((header_len > txq->tso_max_header_len) |
+		     (nb_payload_descs > txq->tso_max_nb_payload_descs) |
+		     (payload_len > txq->tso_max_payload_len) |
+		     (payload_len > mss_conformant_max_payload_len) |
+		     (m->pkt_len == header_len)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'payload_len > mss_conformant_max_payload_len'
#213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123:
+	if (unlikely((header_len > txq->tso_max_header_len) |
+		     (nb_payload_descs > txq->tso_max_nb_payload_descs) |
+		     (payload_len > txq->tso_max_payload_len) |
+		     (payload_len > mss_conformant_max_payload_len) |
+		     (m->pkt_len == header_len)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->pkt_len == header_len'
#213: FILE: drivers/net/sfc/sfc_ef100_tx.c:123:
+	if (unlikely((header_len > txq->tso_max_header_len) |
+		     (nb_payload_descs > txq->tso_max_nb_payload_descs) |
+		     (payload_len > txq->tso_max_payload_len) |
+		     (payload_len > mss_conformant_max_payload_len) |
+		     (m->pkt_len == header_len)))

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#218: FILE: drivers/net/sfc/sfc_ef100_tx.c:128:
+		return EINVAL;

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#386: FILE: drivers/net/sfc/sfc_ef100_tx.c:516:
+			sfc_ef100_tx_qdesc_seg_create(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#396: FILE: drivers/net/sfc/sfc_ef100_tx.c:526:
+			sfc_ef100_tx_qdesc_seg_create(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#403: FILE: drivers/net/sfc/sfc_ef100_tx.c:533:
+			sfc_ef100_tx_qdesc_seg_create(

total: 0 errors, 1 warnings, 8 checks, 407 lines checked


More information about the test-report mailing list