[dpdk-test-report] |WARNING| pw80658 [PATCH v3 36/56] net/txgbe: add VLAN handle support

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Oct 14 08:11:38 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/80658

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#218: FILE: drivers/net/txgbe/txgbe_ethdev.c:46:
+#define TXGBE_SET_HWSTRIP(h, q) do {\
+		uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+		uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+		(h)->bitmap[idx] |= 1 << bit;\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#224: FILE: drivers/net/txgbe/txgbe_ethdev.c:52:
+#define TXGBE_CLEAR_HWSTRIP(h, q) do {\
+		uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+		uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+		(h)->bitmap[idx] &= ~(1 << bit);\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#230: FILE: drivers/net/txgbe/txgbe_ethdev.c:58:
+#define TXGBE_GET_HWSTRIP(h, q, r) do {\
+		uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+		uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+		(r) = (h)->bitmap[idx] >> bit & 1;\
+	} while (0)

total: 0 errors, 0 warnings, 3 checks, 586 lines checked


More information about the test-report mailing list