[dpdk-test-report] |WARNING| pw80990 [PATCH v7 03/20] eal: rename lcore word choices

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Oct 16 00:59:34 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/80990

_coding style issues_


WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#81: 
Replace master lcore with main lcore and

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#82: 
replace slave lcore with worker lcore.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#87: 
The "--master-lcore" command line option is also deprecated

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#156: FILE: doc/guides/rel_notes/release_20_11.rst:433:
+* eal: Changed the function ``rte_get_master_lcore()`` is

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#160: FILE: doc/guides/rel_notes/release_20_11.rst:437:
+  ``RTE_LCORE_FOREACH_SLAVE`` will be replaced with

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#163: FILE: doc/guides/rel_notes/release_20_11.rst:440:
+  The ``master-lcore`` argument to testpmd will be replaced

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#164: FILE: doc/guides/rel_notes/release_20_11.rst:441:
+  with ``main-lcore``. The old ``master-lcore`` argument

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#208: FILE: lib/librte_eal/common/eal_common_launch.c:24:
+rte_eal_wait_lcore(unsigned worker_id)

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#414: FILE: lib/librte_eal/common/eal_common_options.c:1598:
+			"Option --" OPT_MASTER_LCORE

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#631: FILE: lib/librte_eal/freebsd/eal_thread.c:34:
+rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned worker_id)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#794: FILE: lib/librte_eal/include/rte_launch.h:65:
+int rte_eal_remote_launch(lcore_function_t *f, void *arg, unsigned worker_id);

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#810: FILE: lib/librte_eal/include/rte_launch.h:77:
+#define SKIP_MASTER	RTE_DEPRECATED(SKIP_MASTER) SKIP_MAIN

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#810: FILE: lib/librte_eal/include/rte_launch.h:77:
+#define SKIP_MASTER	RTE_DEPRECATED(SKIP_MASTER) SKIP_MAIN

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#810: FILE: lib/librte_eal/include/rte_launch.h:77:
+#define SKIP_MASTER	RTE_DEPRECATED(SKIP_MASTER) SKIP_MAIN

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#811: FILE: lib/librte_eal/include/rte_launch.h:78:
+#define CALL_MASTER	RTE_DEPRECATED(CALL_MASTER) CALL_MAIN

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#811: FILE: lib/librte_eal/include/rte_launch.h:78:
+#define CALL_MASTER	RTE_DEPRECATED(CALL_MASTER) CALL_MAIN

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#811: FILE: lib/librte_eal/include/rte_launch.h:78:
+#define CALL_MASTER	RTE_DEPRECATED(CALL_MASTER) CALL_MAIN

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#882: FILE: lib/librte_eal/include/rte_launch.h:134:
+int rte_eal_wait_lcore(unsigned worker_id);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#923: FILE: lib/librte_eal/include/rte_lcore.h:95:
+static inline unsigned int rte_get_master_lcore(void)

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#967: FILE: lib/librte_eal/include/rte_lcore.h:244:
+#define RTE_LCORE_FOREACH_SLAVE(l)					\

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#967: FILE: lib/librte_eal/include/rte_lcore.h:244:
+#define RTE_LCORE_FOREACH_SLAVE(l)					\
+	RTE_DEPRECATED(RTE_LCORE_FOREACH_SLAVE) RTE_LCORE_FOREACH_WORKER(l)

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#968: FILE: lib/librte_eal/include/rte_lcore.h:245:
+	RTE_DEPRECATED(RTE_LCORE_FOREACH_SLAVE) RTE_LCORE_FOREACH_WORKER(l)

total: 3 errors, 19 warnings, 1076 lines checked
ERROR: symbol rte_get_main_lcore is added in the DPDK_21 section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol rte_get_master_lcore is being removed, ensure that it has gone through the deprecation process


More information about the test-report mailing list