[dpdk-test-report] |WARNING| pw81536 [PATCH v2 20/62] common/sfc_efx/base: support adding DELIVER action to a set

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Oct 20 11:29:20 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/81536

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#177: FILE: drivers/common/sfc_efx/base/efx_mae.c:652:
+	if (arg_size != sizeof (spec->emass_deliver_mport)) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#189: FILE: drivers/common/sfc_efx/base/efx_mae.c:664:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#195: FILE: drivers/common/sfc_efx/base/efx_mae.c:670:
+	return (rc);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_mae_actions_t *' should also have an identifier name
#200: FILE: drivers/common/sfc_efx/base/efx_mae.c:675:
+	efx_rc_t	(*emad_add)(efx_mae_actions_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name
#200: FILE: drivers/common/sfc_efx/base/efx_mae.c:675:
+	efx_rc_t	(*emad_add)(efx_mae_actions_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'const uint8_t *' should also have an identifier name
#200: FILE: drivers/common/sfc_efx/base/efx_mae.c:675:
+	efx_rc_t	(*emad_add)(efx_mae_actions_t *,

ERROR:INITIALISED_STATIC: do not initialise statics to 0
#213: FILE: drivers/common/sfc_efx/base/efx_mae.c:688:
+static const uint32_t efx_mae_action_repeat_map = 0;

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#232: FILE: drivers/common/sfc_efx/base/efx_mae.c:707:
+	    (sizeof (efx_mae_action_ordered_map) * 8));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#234: FILE: drivers/common/sfc_efx/base/efx_mae.c:709:
+	    (sizeof (efx_mae_action_repeat_map) * 8));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#274: FILE: drivers/common/sfc_efx/base/efx_mae.c:749:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#284: FILE: drivers/common/sfc_efx/base/efx_mae.c:759:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#303: FILE: drivers/common/sfc_efx/base/efx_mae.c:778:
+	    EFX_MAE_ACTION_DELIVER, sizeof (mportp->sel), arg));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#307: FILE: drivers/common/sfc_efx/base/efx_mae.c:782:
+	return (rc);

total: 6 errors, 7 warnings, 199 lines checked


More information about the test-report mailing list