[dpdk-test-report] |WARNING| pw76221 [PATCH v1 18/42] net/txgbe: add rx and tx init

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76221

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->offloads == 0'
#249: FILE: drivers/net/txgbe/txgbe_rxtx.c:112:
+	if ((txq->offloads == 0) &&
+			(txq->tx_free_thresh >= RTE_PMD_TXGBE_TX_MAX_BURST)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->tx_free_thresh >= RTE_PMD_TXGBE_TX_MAX_BURST'
#249: FILE: drivers/net/txgbe/txgbe_rxtx.c:112:
+	if ((txq->offloads == 0) &&
+			(txq->tx_free_thresh >= RTE_PMD_TXGBE_TX_MAX_BURST)) {

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#257: FILE: drivers/net/txgbe/txgbe_rxtx.c:120:
+				" - offloads = 0x%" PRIx64,

WARNING:STRING_FRAGMENTS: Consecutive strings are generally better as a single string
#260: FILE: drivers/net/txgbe/txgbe_rxtx.c:123:
+				" - tx_free_thresh = %lu " "[RTE_PMD_TXGBE_TX_MAX_BURST=%lu]",

WARNING:TYPO_SPELLING: 'Regualr' may be misspelled - perhaps 'Regular'?
#307: FILE: drivers/net/txgbe/txgbe_rxtx.c:170:
+			PMD_INIT_LOG(DEBUG, "Using Regualr (non-vector, "

WARNING:TYPO_SPELLING: 'checkum' may be misspelled - perhaps 'checksum'?
#466: FILE: drivers/net/txgbe/txgbe_rxtx.c:329:
+	 * Enable IP/L4 checkum computation by hardware if requested to do so.

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#553: FILE: drivers/net/txgbe/txgbe_rxtx.h:32:
+	/**< Start freeing TX buffers if there are less free descriptors than
+	     this value. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#553: FILE: drivers/net/txgbe/txgbe_rxtx.h:32:
+	     this value. */

total: 0 errors, 5 warnings, 3 checks, 460 lines checked