[dpdk-test-report] |WARNING| pw76229 [PATCH v1 27/42] net/txgbe: add device stats get

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76229

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last_counter' - possible side-effects?
#283: FILE: drivers/net/txgbe/txgbe_ethdev.c:797:
+#define UPDATE_QP_COUNTER_32bit(reg, last_counter, counter)     \
+	{                                                       \
+		uint32_t current_counter = rd32(hw, reg);       \
+		if (current_counter < last_counter)             \
+			current_counter += 0x100000000LL;       \
+		if (!hw->offset_loaded)                         \
+			last_counter = current_counter;         \
+		counter = current_counter - last_counter;       \
+		counter &= 0xFFFFFFFFLL;                        \
+	}

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last_counter' may be better as '(last_counter)' to avoid precedence issues
#283: FILE: drivers/net/txgbe/txgbe_ethdev.c:797:
+#define UPDATE_QP_COUNTER_32bit(reg, last_counter, counter)     \
+	{                                                       \
+		uint32_t current_counter = rd32(hw, reg);       \
+		if (current_counter < last_counter)             \
+			current_counter += 0x100000000LL;       \
+		if (!hw->offset_loaded)                         \
+			last_counter = current_counter;         \
+		counter = current_counter - last_counter;       \
+		counter &= 0xFFFFFFFFLL;                        \
+	}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'counter' - possible side-effects?
#283: FILE: drivers/net/txgbe/txgbe_ethdev.c:797:
+#define UPDATE_QP_COUNTER_32bit(reg, last_counter, counter)     \
+	{                                                       \
+		uint32_t current_counter = rd32(hw, reg);       \
+		if (current_counter < last_counter)             \
+			current_counter += 0x100000000LL;       \
+		if (!hw->offset_loaded)                         \
+			last_counter = current_counter;         \
+		counter = current_counter - last_counter;       \
+		counter &= 0xFFFFFFFFLL;                        \
+	}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last_counter' - possible side-effects?
#294: FILE: drivers/net/txgbe/txgbe_ethdev.c:808:
+#define UPDATE_QP_COUNTER_36bit(reg_lsb, reg_msb, last_counter, counter) \
+	{                                                                \
+		uint64_t current_counter_lsb = rd32(hw, reg_lsb);        \
+		uint64_t current_counter_msb = rd32(hw, reg_msb);        \
+		uint64_t current_counter = (current_counter_msb << 32) | \
+			current_counter_lsb;                             \
+		if (current_counter < last_counter)                      \
+			current_counter += 0x1000000000LL;               \
+		if (!hw->offset_loaded)                                  \
+			last_counter = current_counter;                  \
+		counter = current_counter - last_counter;                \
+		counter &= 0xFFFFFFFFFLL;                                \
+	}

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last_counter' may be better as '(last_counter)' to avoid precedence issues
#294: FILE: drivers/net/txgbe/txgbe_ethdev.c:808:
+#define UPDATE_QP_COUNTER_36bit(reg_lsb, reg_msb, last_counter, counter) \
+	{                                                                \
+		uint64_t current_counter_lsb = rd32(hw, reg_lsb);        \
+		uint64_t current_counter_msb = rd32(hw, reg_msb);        \
+		uint64_t current_counter = (current_counter_msb << 32) | \
+			current_counter_lsb;                             \
+		if (current_counter < last_counter)                      \
+			current_counter += 0x1000000000LL;               \
+		if (!hw->offset_loaded)                                  \
+			last_counter = current_counter;                  \
+		counter = current_counter - last_counter;                \
+		counter &= 0xFFFFFFFFFLL;                                \
+	}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'counter' - possible side-effects?
#294: FILE: drivers/net/txgbe/txgbe_ethdev.c:808:
+#define UPDATE_QP_COUNTER_36bit(reg_lsb, reg_msb, last_counter, counter) \
+	{                                                                \
+		uint64_t current_counter_lsb = rd32(hw, reg_lsb);        \
+		uint64_t current_counter_msb = rd32(hw, reg_msb);        \
+		uint64_t current_counter = (current_counter_msb << 32) | \
+			current_counter_lsb;                             \
+		if (current_counter < last_counter)                      \
+			current_counter += 0x1000000000LL;               \
+		if (!hw->offset_loaded)                                  \
+			last_counter = current_counter;                  \
+		counter = current_counter - last_counter;                \
+		counter &= 0xFFFFFFFFFLL;                                \
+	}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#312: FILE: drivers/net/txgbe/txgbe_ethdev.c:826:
+	unsigned i;

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_MACRX1024toMAXL>
#380: FILE: drivers/net/txgbe/txgbe_ethdev.c:894:
+	hw_stats->rx_size_1024_to_max_packets += rd64(hw, TXGBE_MACRX1024toMAXL);

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_MACTX1024toMAXL>
#386: FILE: drivers/net/txgbe/txgbe_ethdev.c:900:
+	hw_stats->tx_size_1024_to_max_packets += rd64(hw, TXGBE_MACTX1024toMAXL);

total: 0 errors, 1 warnings, 8 checks, 493 lines checked