[dpdk-test-report] |WARNING| pw76240 [PATCH v1 38/42] net/txgbe: add DCB packet buffer allocation

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76240

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#308: FILE: drivers/net/txgbe/base/txgbe_dcb.h:17:
+	 * If 8 traffic classes can be configured, the value is 0x80. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#327: FILE: drivers/net/txgbe/base/txgbe_dcb.h:36:
+			       * in 64B granularity.*/

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name
#374: FILE: drivers/net/txgbe/base/txgbe_dcb.h:83:
+void txgbe_dcb_unpack_map_cee(struct txgbe_dcb_config *, int, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#374: FILE: drivers/net/txgbe/base/txgbe_dcb.h:83:
+void txgbe_dcb_unpack_map_cee(struct txgbe_dcb_config *, int, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#374: FILE: drivers/net/txgbe/base/txgbe_dcb.h:83:
+void txgbe_dcb_unpack_map_cee(struct txgbe_dcb_config *, int, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_dcb_config *' should also have an identifier name
#375: FILE: drivers/net/txgbe/base/txgbe_dcb.h:84:
+u8 txgbe_dcb_get_tc_from_up(struct txgbe_dcb_config *, int, u8);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#375: FILE: drivers/net/txgbe/base/txgbe_dcb.h:84:
+u8 txgbe_dcb_get_tc_from_up(struct txgbe_dcb_config *, int, u8);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#375: FILE: drivers/net/txgbe/base/txgbe_dcb.h:84:
+u8 txgbe_dcb_get_tc_from_up(struct txgbe_dcb_config *, int, u8);

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#421: FILE: drivers/net/txgbe/base/txgbe_hw.c:1795:
+		/* fall through - configure remaining packet buffers */

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pfc_conf->fc.high_water > max_high_water'
#625: FILE: drivers/net/txgbe/txgbe_ethdev.c:2629:
+	if ((pfc_conf->fc.high_water > max_high_water) ||
+	    (pfc_conf->fc.high_water <= pfc_conf->fc.low_water)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pfc_conf->fc.high_water <= pfc_conf->fc.low_water'
#625: FILE: drivers/net/txgbe/txgbe_ethdev.c:2629:
+	if ((pfc_conf->fc.high_water > max_high_water) ||
+	    (pfc_conf->fc.high_water <= pfc_conf->fc.low_water)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == 0'
#641: FILE: drivers/net/txgbe/txgbe_ethdev.c:2645:
+	if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == TXGBE_ERR_FC_NOT_NEGOTIATED'
#641: FILE: drivers/net/txgbe/txgbe_ethdev.c:2645:
+	if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around dev->data->dev_conf
#700: FILE: drivers/net/txgbe/txgbe_rxtx.c:2765:
+	struct rte_eth_conf *dev_conf = &(dev->data->dev_conf);

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#738: FILE: drivers/net/txgbe/txgbe_rxtx.c:2803:
+		wr32m(hw, TXGBE_TAGTPID(i/2),
 		                         ^

total: 0 errors, 9 warnings, 6 checks, 613 lines checked