[dpdk-test-report] |WARNING| pw77075 [PATCH 11/12] net/bnxt: handle multiple packets per loop in vector PMD

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 9 17:57:58 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/77075

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pi' - possible side-effects?
#217: FILE: drivers/net/bnxt/bnxt_rxtx_vec_neon.c:25:
+#define GET_OL_FLAGS(rss_flags, ol_idx, errors, pi, ol_flags)		       \
+{									       \
+	uint32_t tmp, of;						       \
+									       \
+	of = vgetq_lane_u32((rss_flags), (pi)) |			       \
+		   bnxt_ol_flags_table[vgetq_lane_u32((ol_idx), (pi))];	       \
+									       \
+	tmp = vgetq_lane_u32((errors), (pi));				       \
+	if (tmp)							       \
+		of |= bnxt_ol_flags_err_table[tmp];			       \
+	(ol_flags) = of;						       \
+}

WARNING:TYPO_SPELLING: 'curent' may be misspelled - perhaps 'current'?
#488: FILE: drivers/net/bnxt/bnxt_rxtx_vec_neon.c:257:
+		 * Load the four curent descriptors into SSE registers in

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#536: FILE: drivers/net/bnxt/bnxt_rxtx_vec_neon.c:305:
+			/* FALLTHROUGH */

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#539: FILE: drivers/net/bnxt/bnxt_rxtx_vec_neon.c:308:
+			/* FALLTHROUGH */

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#542: FILE: drivers/net/bnxt/bnxt_rxtx_vec_neon.c:311:
+			/* FALLTHROUGH */

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pi' - possible side-effects?
#650: FILE: drivers/net/bnxt/bnxt_rxtx_vec_sse.c:25:
+#define GET_OL_FLAGS(rss_flags, ol_index, errors, pi, ol_flags)		       \
+{									       \
+	uint32_t tmp, of;						       \
+									       \
+	of = _mm_extract_epi32((rss_flags), (pi)) |			       \
+		bnxt_ol_flags_table[_mm_extract_epi32((ol_index), (pi))];      \
+									       \
+	tmp = _mm_extract_epi32((errors), (pi));			       \
+	if (tmp)							       \
+		of |= bnxt_ol_flags_err_table[tmp];			       \
+	(ol_flags) = of;						       \
+}

WARNING:TYPO_SPELLING: 'curent' may be misspelled - perhaps 'current'?
#897: FILE: drivers/net/bnxt/bnxt_rxtx_vec_sse.c:237:
+		 * Load the four curent descriptors into SSE registers in

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#956: FILE: drivers/net/bnxt/bnxt_rxtx_vec_sse.c:276:
+			/* FALLTHROUGH */

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#959: FILE: drivers/net/bnxt/bnxt_rxtx_vec_sse.c:279:
+			/* FALLTHROUGH */

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#962: FILE: drivers/net/bnxt/bnxt_rxtx_vec_sse.c:282:
+			/* FALLTHROUGH */

total: 0 errors, 8 warnings, 2 checks, 857 lines checked


More information about the test-report mailing list