[dpdk-test-report] |WARNING| pw77127 [PATCH v1 3/3] net/ice: support ACL filter in DCF

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Sep 10 09:43:10 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/77127

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_mask->hdr.src_addr == UINT32_MAX'
#891: FILE: drivers/net/ice/ice_acl_filter.c:810:
+				if ((ipv4_mask->hdr.src_addr == UINT32_MAX) ||
+				    (ipv4_mask->hdr.dst_addr == UINT32_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_mask->hdr.dst_addr == UINT32_MAX'
#891: FILE: drivers/net/ice/ice_acl_filter.c:810:
+				if ((ipv4_mask->hdr.src_addr == UINT32_MAX) ||
+				    (ipv4_mask->hdr.dst_addr == UINT32_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_spec->hdr.src_addr != 0'
#900: FILE: drivers/net/ice/ice_acl_filter.c:819:
+				if ((ipv4_spec->hdr.src_addr != 0) &&
+				    (ipv4_mask->hdr.src_addr != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_mask->hdr.src_addr != 0'
#900: FILE: drivers/net/ice/ice_acl_filter.c:819:
+				if ((ipv4_spec->hdr.src_addr != 0) &&
+				    (ipv4_mask->hdr.src_addr != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_spec->hdr.dst_addr != 0'
#910: FILE: drivers/net/ice/ice_acl_filter.c:829:
+				if ((ipv4_spec->hdr.dst_addr != 0) &&
+				    (ipv4_mask->hdr.dst_addr != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_mask->hdr.dst_addr != 0'
#910: FILE: drivers/net/ice/ice_acl_filter.c:829:
+				if ((ipv4_spec->hdr.dst_addr != 0) &&
+				    (ipv4_mask->hdr.dst_addr != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_mask->hdr.src_port == UINT16_MAX'
#943: FILE: drivers/net/ice/ice_acl_filter.c:862:
+				if ((tcp_mask->hdr.src_port == UINT16_MAX) ||
+				    (tcp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_mask->hdr.dst_port == UINT16_MAX'
#943: FILE: drivers/net/ice/ice_acl_filter.c:862:
+				if ((tcp_mask->hdr.src_port == UINT16_MAX) ||
+				    (tcp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_mask->hdr.src_port == UINT16_MAX'
#952: FILE: drivers/net/ice/ice_acl_filter.c:871:
+				if ((tcp_mask->hdr.src_port == UINT16_MAX) ||
+				    (tcp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_mask->hdr.dst_port == UINT16_MAX'
#952: FILE: drivers/net/ice/ice_acl_filter.c:871:
+				if ((tcp_mask->hdr.src_port == UINT16_MAX) ||
+				    (tcp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#961: FILE: drivers/net/ice/ice_acl_filter.c:880:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (tcp_spec->hdr.src_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_spec->hdr.src_port != 0'
#961: FILE: drivers/net/ice/ice_acl_filter.c:880:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (tcp_spec->hdr.src_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#970: FILE: drivers/net/ice/ice_acl_filter.c:889:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (tcp_spec->hdr.dst_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_spec->hdr.dst_port != 0'
#970: FILE: drivers/net/ice/ice_acl_filter.c:889:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (tcp_spec->hdr.dst_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'udp_mask->hdr.src_port == UINT16_MAX'
#999: FILE: drivers/net/ice/ice_acl_filter.c:918:
+				if ((udp_mask->hdr.src_port == UINT16_MAX) ||
+				    (udp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'udp_mask->hdr.dst_port == UINT16_MAX'
#999: FILE: drivers/net/ice/ice_acl_filter.c:918:
+				if ((udp_mask->hdr.src_port == UINT16_MAX) ||
+				    (udp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#1009: FILE: drivers/net/ice/ice_acl_filter.c:928:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (udp_spec->hdr.src_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'udp_spec->hdr.src_port != 0'
#1009: FILE: drivers/net/ice/ice_acl_filter.c:928:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (udp_spec->hdr.src_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#1018: FILE: drivers/net/ice/ice_acl_filter.c:937:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (udp_spec->hdr.dst_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'udp_spec->hdr.dst_port != 0'
#1018: FILE: drivers/net/ice/ice_acl_filter.c:937:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (udp_spec->hdr.dst_port != 0)) {

total: 0 errors, 0 warnings, 20 checks, 1119 lines checked


More information about the test-report mailing list