[dpdk-test-report] |WARNING| pw77469 [PATCH 02/15] eal: rename lcore word choices

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 11 21:08:43 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/77469

_coding style issues_


WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#79: 
Replace master lcore with main lcore and

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#80: 
replace slave lcore with worker lcore.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#85: 
The "--master-lcore" command line option is also deprecated

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#153: FILE: doc/guides/rel_notes/release_20_11.rst:96:
+* eal: Changed the function ``rte_get_master_lcore()`` is

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#157: FILE: doc/guides/rel_notes/release_20_11.rst:100:
+  ``RTE_LCORE_FOREACH_SLAVE`` will be replaced with

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#160: FILE: doc/guides/rel_notes/release_20_11.rst:103:
+  The ``master-lcore`` argument to testpmd will be replaced

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#161: FILE: doc/guides/rel_notes/release_20_11.rst:104:
+  with ``main-lcore``. The old ``master-lcore`` argument

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#197: FILE: lib/librte_eal/common/eal_common_launch.c:24:
+rte_eal_wait_lcore(unsigned worker_id)

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#399: FILE: lib/librte_eal/common/eal_common_options.c:1598:
+			"option --" OPT_MASTER_LCORE

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#401: FILE: lib/librte_eal/common/eal_common_options.c:1600:
+		/* fallthrough */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#602: FILE: lib/librte_eal/freebsd/eal_thread.c:34:
+rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned worker_id)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#765: FILE: lib/librte_eal/include/rte_launch.h:65:
+int rte_eal_remote_launch(lcore_function_t *f, void *arg, unsigned worker_id);

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#780: FILE: lib/librte_eal/include/rte_launch.h:76:
+#define SKIP_MASTER 	RTE_DEPRECATED(SKIP_MASTER, SKIP_MAIN)	SKIP_MAIN

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#780: FILE: lib/librte_eal/include/rte_launch.h:76:
+#define SKIP_MASTER 	RTE_DEPRECATED(SKIP_MASTER, SKIP_MAIN)	SKIP_MAIN

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#780: FILE: lib/librte_eal/include/rte_launch.h:76:
+#define SKIP_MASTER ^IRTE_DEPRECATED(SKIP_MASTER, SKIP_MAIN)^ISKIP_MAIN$

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#780: FILE: lib/librte_eal/include/rte_launch.h:76:
+#define SKIP_MASTER 	RTE_DEPRECATED(SKIP_MASTER, SKIP_MAIN)	SKIP_MAIN

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#781: FILE: lib/librte_eal/include/rte_launch.h:77:
+#define CALL_MASTER 	RTE_DEPRECATED(CALL_MASTER, CALL_MAIN)	CALL_MAIN

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#781: FILE: lib/librte_eal/include/rte_launch.h:77:
+#define CALL_MASTER 	RTE_DEPRECATED(CALL_MASTER, CALL_MAIN)	CALL_MAIN

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#781: FILE: lib/librte_eal/include/rte_launch.h:77:
+#define CALL_MASTER ^IRTE_DEPRECATED(CALL_MASTER, CALL_MAIN)^ICALL_MAIN$

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#781: FILE: lib/librte_eal/include/rte_launch.h:77:
+#define CALL_MASTER 	RTE_DEPRECATED(CALL_MASTER, CALL_MAIN)	CALL_MAIN

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#826: FILE: lib/librte_eal/include/rte_launch.h:113:
+enum rte_lcore_state_t rte_eal_get_lcore_state(unsigned worker_id);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#852: FILE: lib/librte_eal/include/rte_launch.h:133:
+int rte_eal_wait_lcore(unsigned worker_id);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#893: FILE: lib/librte_eal/include/rte_lcore.h:95:
+static inline unsigned int rte_get_master_lcore(void)

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#937: FILE: lib/librte_eal/include/rte_lcore.h:244:
+#define RTE_LCORE_FOREACH_SLAVE(l)					\

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#937: FILE: lib/librte_eal/include/rte_lcore.h:244:
+#define RTE_LCORE_FOREACH_SLAVE(l)					\
+	RTE_DEPRECATED(RTE_LCORE_FOREACH_SLAVE, RTE_LCORE_FOREACH_WORKER) \
+	RTE_LCORE_FOREACH_WORKER(l)

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#938: FILE: lib/librte_eal/include/rte_lcore.h:245:
+	RTE_DEPRECATED(RTE_LCORE_FOREACH_SLAVE, RTE_LCORE_FOREACH_WORKER) \

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1063: FILE: lib/librte_eal/linux/eal_thread.c:34:
+rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned worker_id)

total: 3 errors, 24 warnings, 1043 lines checked
ERROR: symbol rte_get_main_lcore is added in the DPDK_21 section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol rte_get_master_lcore is being removed, ensure that it has gone through the deprecation process


More information about the test-report mailing list