[dpdk-test-report] |WARNING| pw77702 [PATCH 2/2] Add l2reflect measurement application

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Sep 15 10:40:02 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/77702

_coding style issues_


WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#198: FILE: app/l2reflect/l2reflect.h:40:
+extern int l2reflect_hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#199: FILE: app/l2reflect/l2reflect.h:41:
+extern atomic_int l2reflect_output_hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#233: FILE: app/l2reflect/main.c:21:
+ *   jitterplot hist histogram.json

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#310: FILE: app/l2reflect/main.c:98:
+int l2reflect_hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#311: FILE: app/l2reflect/main.c:99:
+atomic_int l2reflect_output_hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#391: FILE: app/l2reflect/main.c:179:
+	hist_filename = NULL;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#392: FILE: app/l2reflect/main.c:180:
+	l2reflect_output_hist = 0;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#432: FILE: app/l2reflect/main.c:220:
+			l2reflect_hist = 1;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#433: FILE: app/l2reflect/main.c:221:
+			hist_bucket_usec = strtoul(optarg, NULL, 10);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#440: FILE: app/l2reflect/main.c:228:
+			hist_filename = strndup(optarg, 128);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#458: FILE: app/l2reflect/main.c:246:
+	if (hist_filename && !l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#458: FILE: app/l2reflect/main.c:246:
+	if (hist_filename && !l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#761: FILE: app/l2reflect/main.c:549:
+		if (l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#763: FILE: app/l2reflect/main.c:551:
+				MIN(diff / (hist_bucket_usec * 1000),

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#764: FILE: app/l2reflect/main.c:552:
+				    HIST_CAP_BUCKET);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#765: FILE: app/l2reflect/main.c:553:
+			record.hist[bucket]++;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#960: FILE: app/l2reflect/main.c:748:
+		l2reflect_output_hist = 1;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1082: FILE: app/l2reflect/main.c:870:
+	 * in quiet mode the master executes the main packet loop

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#1083: FILE: app/l2reflect/main.c:871:
+	 * otherwise the one slave does it and the master prints stats

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1083: FILE: app/l2reflect/main.c:871:
+	 * otherwise the one slave does it and the master prints stats

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#1096: FILE: app/l2reflect/main.c:884:
+		/* the slave reflects the packets */

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#1097: FILE: app/l2reflect/main.c:885:
+		RTE_LCORE_FOREACH_SLAVE(lcore_id)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1103: FILE: app/l2reflect/main.c:891:
+		/* the master prints the stats */

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1110: FILE: app/l2reflect/main.c:898:
+	if (l2reflect_hist)

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1170: FILE: app/l2reflect/stats.c:14:
+unsigned int hist_bucket_usec;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1172: FILE: app/l2reflect/stats.c:16:
+char *hist_filename;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1182: FILE: app/l2reflect/stats.c:26:
+	if (l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1183: FILE: app/l2reflect/stats.c:27:
+		if (!record.hist_size) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1184: FILE: app/l2reflect/stats.c:28:
+			record.hist =

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1185: FILE: app/l2reflect/stats.c:29:
+				calloc(HIST_NUM_BUCKETS, sizeof(uint64_t));

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1186: FILE: app/l2reflect/stats.c:30:
+			record.hist_size = HIST_NUM_BUCKETS;

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1186: FILE: app/l2reflect/stats.c:30:
+			record.hist_size = HIST_NUM_BUCKETS;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1188: FILE: app/l2reflect/stats.c:32:
+			memset(record.hist, 0,

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1189: FILE: app/l2reflect/stats.c:33:
+			       record.hist_size * sizeof(uint64_t));

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1197: FILE: app/l2reflect/stats.c:41:
+	if (l2reflect_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1198: FILE: app/l2reflect/stats.c:42:
+		free(record.hist);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1199: FILE: app/l2reflect/stats.c:43:
+		record.hist = NULL;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1200: FILE: app/l2reflect/stats.c:44:
+		record.hist_size = 0;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1209: FILE: app/l2reflect/stats.c:53:
+	if (hist_filename)

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1210: FILE: app/l2reflect/stats.c:54:
+		fd = fopen(hist_filename, "w");

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1214: FILE: app/l2reflect/stats.c:58:
+	if (hist_filename)

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1278: FILE: app/l2reflect/stats.c:122:
+		if (l2reflect_hist && l2reflect_output_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1278: FILE: app/l2reflect/stats.c:122:
+		if (l2reflect_hist && l2reflect_output_hist) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1280: FILE: app/l2reflect/stats.c:124:
+			l2reflect_output_hist = 0;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1295: FILE: app/l2reflect/stats.c:139:
+	json_t *hist0, *cpu0, *all_cpus, *output;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1302: FILE: app/l2reflect/stats.c:146:
+	hist0 = json_object();

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1303: FILE: app/l2reflect/stats.c:147:
+	for (i = 0; i < record->hist_size; ++i) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1305: FILE: app/l2reflect/stats.c:149:
+		if (record->hist[i] != 0) {

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1306: FILE: app/l2reflect/stats.c:150:
+			snprintf(key, 8, "%u", i * hist_bucket_usec);

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1307: FILE: app/l2reflect/stats.c:151:
+			json_object_set(hist0, key,

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1308: FILE: app/l2reflect/stats.c:152:
+					json_integer(record->hist[i]));

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1314: FILE: app/l2reflect/stats.c:158:
+	json_object_set_new(cpu0, "histogram", hist0);

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1355: FILE: app/l2reflect/stats.h:15:
+#define HIST_NUM_BUCKETS 128

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1356: FILE: app/l2reflect/stats.h:16:
+#define HIST_CAP_BUCKET (HIST_NUM_BUCKETS - 1)

WARNING:TYPO_SPELLING: 'HIST' may be misspelled - perhaps 'HEIST'?
#1356: FILE: app/l2reflect/stats.h:16:
+#define HIST_CAP_BUCKET (HIST_NUM_BUCKETS - 1)

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1365: FILE: app/l2reflect/stats.h:25:
+	unsigned int hist_size;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1367: FILE: app/l2reflect/stats.h:27:
+	uint64_t *hist;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1371: FILE: app/l2reflect/stats.h:31:
+extern unsigned int hist_bucket_usec;

WARNING:TYPO_SPELLING: 'hist' may be misspelled - perhaps 'heist'?
#1373: FILE: app/l2reflect/stats.h:33:
+extern char *hist_filename;

total: 0 errors, 59 warnings, 1279 lines checked


More information about the test-report mailing list