[dpdk-test-report] |WARNING| pw79127 [PATCH v2 3/4] net/ice: support ACL filter in DCF

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79127

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_mask->hdr.src_addr == UINT32_MAX'
#845: FILE: drivers/net/ice/ice_acl_filter.c:745:
+				if ((ipv4_mask->hdr.src_addr == UINT32_MAX) ||
+				    (ipv4_mask->hdr.dst_addr == UINT32_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_mask->hdr.dst_addr == UINT32_MAX'
#845: FILE: drivers/net/ice/ice_acl_filter.c:745:
+				if ((ipv4_mask->hdr.src_addr == UINT32_MAX) ||
+				    (ipv4_mask->hdr.dst_addr == UINT32_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_spec->hdr.src_addr != 0'
#854: FILE: drivers/net/ice/ice_acl_filter.c:754:
+				if ((ipv4_spec->hdr.src_addr != 0) &&
+				    (ipv4_mask->hdr.src_addr != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_mask->hdr.src_addr != 0'
#854: FILE: drivers/net/ice/ice_acl_filter.c:754:
+				if ((ipv4_spec->hdr.src_addr != 0) &&
+				    (ipv4_mask->hdr.src_addr != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_spec->hdr.dst_addr != 0'
#864: FILE: drivers/net/ice/ice_acl_filter.c:764:
+				if ((ipv4_spec->hdr.dst_addr != 0) &&
+				    (ipv4_mask->hdr.dst_addr != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_mask->hdr.dst_addr != 0'
#864: FILE: drivers/net/ice/ice_acl_filter.c:764:
+				if ((ipv4_spec->hdr.dst_addr != 0) &&
+				    (ipv4_mask->hdr.dst_addr != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_mask->hdr.src_port == UINT16_MAX'
#897: FILE: drivers/net/ice/ice_acl_filter.c:797:
+				if ((tcp_mask->hdr.src_port == UINT16_MAX) ||
+				    (tcp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_mask->hdr.dst_port == UINT16_MAX'
#897: FILE: drivers/net/ice/ice_acl_filter.c:797:
+				if ((tcp_mask->hdr.src_port == UINT16_MAX) ||
+				    (tcp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_mask->hdr.src_port == UINT16_MAX'
#906: FILE: drivers/net/ice/ice_acl_filter.c:806:
+				if ((tcp_mask->hdr.src_port == UINT16_MAX) ||
+				    (tcp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_mask->hdr.dst_port == UINT16_MAX'
#906: FILE: drivers/net/ice/ice_acl_filter.c:806:
+				if ((tcp_mask->hdr.src_port == UINT16_MAX) ||
+				    (tcp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#915: FILE: drivers/net/ice/ice_acl_filter.c:815:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (tcp_spec->hdr.src_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_spec->hdr.src_port != 0'
#915: FILE: drivers/net/ice/ice_acl_filter.c:815:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (tcp_spec->hdr.src_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#924: FILE: drivers/net/ice/ice_acl_filter.c:824:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (tcp_spec->hdr.dst_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_spec->hdr.dst_port != 0'
#924: FILE: drivers/net/ice/ice_acl_filter.c:824:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (tcp_spec->hdr.dst_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'udp_mask->hdr.src_port == UINT16_MAX'
#953: FILE: drivers/net/ice/ice_acl_filter.c:853:
+				if ((udp_mask->hdr.src_port == UINT16_MAX) ||
+				    (udp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'udp_mask->hdr.dst_port == UINT16_MAX'
#953: FILE: drivers/net/ice/ice_acl_filter.c:853:
+				if ((udp_mask->hdr.src_port == UINT16_MAX) ||
+				    (udp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#962: FILE: drivers/net/ice/ice_acl_filter.c:862:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (udp_spec->hdr.src_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'udp_spec->hdr.src_port != 0'
#962: FILE: drivers/net/ice/ice_acl_filter.c:862:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (udp_spec->hdr.src_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#971: FILE: drivers/net/ice/ice_acl_filter.c:871:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (udp_spec->hdr.dst_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'udp_spec->hdr.dst_port != 0'
#971: FILE: drivers/net/ice/ice_acl_filter.c:871:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (udp_spec->hdr.dst_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'sctp_mask->hdr.src_port == UINT16_MAX'
#990: FILE: drivers/net/ice/ice_acl_filter.c:890:
+				if ((sctp_mask->hdr.src_port == UINT16_MAX) ||
+				    (sctp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'sctp_mask->hdr.dst_port == UINT16_MAX'
#990: FILE: drivers/net/ice/ice_acl_filter.c:890:
+				if ((sctp_mask->hdr.src_port == UINT16_MAX) ||
+				    (sctp_mask->hdr.dst_port == UINT16_MAX)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#999: FILE: drivers/net/ice/ice_acl_filter.c:899:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (sctp_spec->hdr.src_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'sctp_spec->hdr.src_port != 0'
#999: FILE: drivers/net/ice/ice_acl_filter.c:899:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (sctp_spec->hdr.src_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#1008: FILE: drivers/net/ice/ice_acl_filter.c:908:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (sctp_spec->hdr.dst_port != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'sctp_spec->hdr.dst_port != 0'
#1008: FILE: drivers/net/ice/ice_acl_filter.c:908:
+				if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+				    (sctp_spec->hdr.dst_port != 0)) {

total: 0 errors, 0 warnings, 26 checks, 1157 lines checked