[dpdk-test-report] |WARNING| pw91998 [PATCH v1 1/1] power: add support for cppc cpufreq

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Apr 22 08:16:38 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/91998

_coding style issues_


WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#125: FILE: lib/power/power_cppc_cpufreq.c:12:
+#define POWER_DEBUG_TRACE(fmt, args...) do { \
+		RTE_LOG(ERR, POWER, "%s: " fmt, __func__, ## args); \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#132: FILE: lib/power/power_cppc_cpufreq.c:19:
+#define FOPEN_OR_ERR_RET(f, retval) do { \
+		if ((f) == NULL) { \
+			RTE_LOG(ERR, POWER, "File not opened
"); \
+			return retval; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#139: FILE: lib/power/power_cppc_cpufreq.c:26:
+#define FOPS_OR_NULL_GOTO(ret, label) do { \
+		if ((ret) == NULL) { \
+			RTE_LOG(ERR, POWER, "fgets returns nothing
"); \
+			goto label; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#146: FILE: lib/power/power_cppc_cpufreq.c:33:
+#define FOPS_OR_ERR_GOTO(ret, label) do { \
+		if ((ret) < 0) { \
+			RTE_LOG(ERR, POWER, "File operations failed
"); \
+			goto label; \
+		} \
+} while (0)

total: 0 errors, 4 warnings, 1131 lines checked


More information about the test-report mailing list