[dpdk-test-report] |WARNING| pw92584 [RFC 1/1] app/testpmd: add l3fwd mode to testpmd

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Apr 30 23:39:46 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/92584

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#368: FILE: app/test-pmd/l3fwd.c:189:
+	unsigned i;

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#481: FILE: app/test-pmd/l3fwd.c:302:
+	 * TX burst queue drain
+	*/

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#497: FILE: app/test-pmd/l3fwd.c:318:
+       /*
+	 * Receive a burst of packets and forward them.

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#525: FILE: app/test-pmd/l3fwd.c:346:
+	/* TODO check l3fwd_poll_resource_setup to see what must be done on
+		a port level, esp init ports_eth_addr[] */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#525: FILE: app/test-pmd/l3fwd.c:346:
+		a port level, esp init ports_eth_addr[] */

WARNING:TYPO_SPELLING: 'destionation' may be misspelled - perhaps 'destination'?
#744: FILE: app/test-pmd/l3fwd_common.h:54:
+ * We group consecutive packets with the same destionation port into one burst.

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#905: FILE: app/test-pmd/l3fwd_common.h:215:
+	while (j < n) {
+	case 0:

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16)
#935: FILE: app/test-pmd/l3fwd_common.h:245:
+		while (j < len) {
+		case 0:

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#1003: FILE: app/test-pmd/l3fwd_lpm.h:39:
+	       /* if (dst_port >= RTE_MAX_ETHPORTS ||
+			(enabled_port_mask & 1 << dst_port) == 0)

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#1030: FILE: app/test-pmd/l3fwd_lpm.h:66:
+		/*TODO check if port is enabled
+		if (dst_port >= RTE_MAX_ETHPORTS ||

WARNING:TYPO_SPELLING: 'destionation' may be misspelled - perhaps 'destination'?
#1319: FILE: app/test-pmd/l3fwd_neon.h:67:
+ * Suppose we have array of destionation ports:

total: 0 errors, 11 warnings, 1460 lines checked


More information about the test-report mailing list