[dpdk-test-report] |WARNING| pw88008 [PATCH 5/7] net/qede: changes for DMA page chain allocation and free

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Feb 19 11:16:28 CET 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/88008

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'elem_size' - possible side-effects?
#274: FILE: drivers/net/qede/base/ecore_chain.h:173:
+#define USABLE_ELEMS_PER_PAGE(elem_size, page_size, mode)		\
+	  ((u32)(ELEMS_PER_PAGE(page_size, elem_size) -			\
+	   UNUSABLE_ELEMS_PER_PAGE(elem_size, mode)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#392: FILE: drivers/net/qede/base/ecore_chain.h:383:
+#define test_and_skip(p, idx)							\
+	do {									\
+		if (is_chain_u16(p)) {						\
+			if (is_unusable_idx(p, idx))				\
+				(p)->u.chain16.idx += (p)->elem_unusable;	\
+		} else {							\
+			if (is_unusable_idx_u32(p, idx))			\
+				(p)->u.chain32.idx += (p)->elem_unusable;	\
+		}								\
 	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#392: FILE: drivers/net/qede/base/ecore_chain.h:383:
+#define test_and_skip(p, idx)							\
+	do {									\
+		if (is_chain_u16(p)) {						\
+			if (is_unusable_idx(p, idx))				\
+				(p)->u.chain16.idx += (p)->elem_unusable;	\
+		} else {							\
+			if (is_unusable_idx_u32(p, idx))			\
+				(p)->u.chain32.idx += (p)->elem_unusable;	\
+		}								\
 	} while (0)

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#701: FILE: drivers/net/qede/base/ecore_dev.c:7857:
+			  "The actual chain size (0x%" PRIx64 ") is larger than the maximal possible value
",

total: 0 errors, 0 warnings, 4 checks, 975 lines checked


More information about the test-report mailing list