[dpdk-test-report] |WARNING| pw86087 [PATCH v2 3/6] net/iavf_be: virtchnl messages process

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/86087

_coding style issues_


WARNING:TYPO_SPELLING: 'implemention' may be misspelled - perhaps 'implementation'?
#61: 
2. Ethdev ops implemention for queues setup.

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#230: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:129:
+	unsigned i;

WARNING:TYPO_SPELLING: 'memeory' may be misspelled - perhaps 'memory'?
#597: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:775:
+		IAVF_BE_LOG(ERR, "fail to allocate memeory for queue info");

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around adapter->mem_table
#1041: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:219:
+	struct rte_iavf_emu_mem **mem = &(adapter->mem_table);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1267: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:445:
+			rxq->tx_ring = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr(

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1274: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:452:
+
+		}

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1290: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:468:
+
+		}

WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#1419: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:597:
+		adapter->eth_stats.tx_broadcast += rxq->stats.recv_broad_num;;

WARNING:TYPO_SPELLING: 'Dont' may be misspelled - perhaps 'Don't'?
#1434: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:612:
+		/* Dont add discards as recv count doesn't include this part */

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#1441: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:619:
+	IAVF_BE_LOG(DEBUG, "rx_bytes:            %"PRIu64"",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1441: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:619:
+	IAVF_BE_LOG(DEBUG, "rx_bytes:            %"PRIu64"",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1443: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:621:
+	IAVF_BE_LOG(DEBUG, "rx_unicast:          %"PRIu64"",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1445: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:623:
+	IAVF_BE_LOG(DEBUG, "rx_multicast:        %"PRIu64"",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1447: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:625:
+	IAVF_BE_LOG(DEBUG, "rx_broadcast:        %"PRIu64"",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1449: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:627:
+	IAVF_BE_LOG(DEBUG, "rx_discards:         %"PRIu64"",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1452: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:630:
+	IAVF_BE_LOG(DEBUG, "tx_bytes:            %"PRIu64"",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1454: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:632:
+	IAVF_BE_LOG(DEBUG, "tx_unicast:          %"PRIu64"",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1456: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:634:
+	IAVF_BE_LOG(DEBUG, "tx_multicast:        %"PRIu64"",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1458: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:636:
+	IAVF_BE_LOG(DEBUG, "tx_broadcast:        %"PRIu64"",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1460: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:638:
+	IAVF_BE_LOG(DEBUG, "tx_discards:         %"PRIu64"",

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1567: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:811:
+	for (i = 0; i < addr_list->num_elements; i++) {
+
+		/* TODO: mac filter havn't been enabled yet */
+
+	}

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1568: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:812:
+	for (i = 0; i < addr_list->num_elements; i++) {
+

WARNING:TYPO_SPELLING: 'havn't' may be misspelled - perhaps 'haven't'?
#1569: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:813:
+		/* TODO: mac filter havn't been enabled yet */

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1571: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:815:
+
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1594: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:838:
+	for (i = 0; i < addr_list->num_elements; i++) {
+
+		/* TODO: mac filter havn't been enabled yet */
+
+	}

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1595: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:839:
+	for (i = 0; i < addr_list->num_elements; i++) {
+

WARNING:TYPO_SPELLING: 'havn't' may be misspelled - perhaps 'haven't'?
#1596: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:840:
+		/* TODO: mac filter havn't been enabled yet */

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1598: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:842:
+
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1620: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:864:
+	for (i = 0; i < vlan_list->num_elements; i++) {
+
+		/* TODO: vlan filter havn't been enabled yet */
+
+	}

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1621: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:865:
+	for (i = 0; i < vlan_list->num_elements; i++) {
+

WARNING:TYPO_SPELLING: 'havn't' may be misspelled - perhaps 'haven't'?
#1622: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:866:
+		/* TODO: vlan filter havn't been enabled yet */

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1624: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:868:
+
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1647: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:891:
+	for (i = 0; i < vlan_list->num_elements; i++) {
+
+		/* TODO: vlan filter havn't been enabled yet */
+
+	}

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1648: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:892:
+	for (i = 0; i < vlan_list->num_elements; i++) {
+

WARNING:TYPO_SPELLING: 'havn't' may be misspelled - perhaps 'haven't'?
#1649: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:893:
+		/* TODO: vlan filter havn't been enabled yet */

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1651: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:895:
+
+	}

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1666: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:910:
+	msg_opc = (enum virtchnl_ops)rte_le_to_cpu_32(

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1759: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:1003:
+
+}

total: 0 errors, 13 warnings, 25 checks, 1653 lines checked
Warning in drivers/net/iavf_be/iavf_be_ethdev.c:
Using rte_atomicNN_xxx