[dpdk-test-report] |WARNING| pw93916 [PATCH v8 05/10] eal: implement thread priority management functions

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Jun 5 01:40:18 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93916

_coding style issues_


ERROR:OPEN_BRACE: that open brace { should be on the previous line
#105: FILE: lib/eal/common/rte_thread.c:61:
+	switch (eal_pri)
+	{

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#125: FILE: lib/eal/common/rte_thread.c:81:
+			return EINVAL;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#139: FILE: lib/eal/common/rte_thread.c:95:
+	if (ret != 0) {
+		return ret;
+	}

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#234: FILE: lib/eal/windows/rte_thread.c:230:
+	switch (eal_pri)
+	{

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#246: FILE: lib/eal/windows/rte_thread.c:242:
+			return EINVAL;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#270: FILE: lib/eal/windows/rte_thread.c:266:
+	if (ret != 0) {
+		return ret;
+	}

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 3 errors, 4 warnings, 192 lines checked


More information about the test-report mailing list