[dpdk-test-report] |WARNING| pw93929 [PATCH v9 07/10] eal: implement functions for mutex management
checkpatch at dpdk.org
checkpatch at dpdk.org
Sat Jun 5 01:45:56 CEST 2021
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93929
_coding style issues_
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#208: FILE: lib/eal/windows/include/rte_windows_thread_types.h:10:
+#define WINDOWS_MUTEX_INITIALIZER (void*)-1
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#208: FILE: lib/eal/windows/include/rte_windows_thread_types.h:10:
+#define WINDOWS_MUTEX_INITIALIZER (void*)-1
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#212: FILE: lib/eal/windows/include/rte_windows_thread_types.h:14:
+ void* mutex_id;
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#253: FILE: lib/eal/windows/rte_thread.c:500:
+ void* id = 0;
WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#259: FILE: lib/eal/windows/rte_thread.c:506:
+ id = InterlockedCompareExchangePointer(&mutex->mutex_id, mutex->mutex_id, WINDOWS_MUTEX_INITIALIZER);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#263: FILE: lib/eal/windows/rte_thread.c:510:
+ if (ret != 0) {
+ return ret;
+ }
WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#267: FILE: lib/eal/windows/rte_thread.c:514:
+ id = InterlockedCompareExchangePointer(&mutex->mutex_id, m.mutex_id, WINDOWS_MUTEX_INITIALIZER);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#271: FILE: lib/eal/windows/rte_thread.c:518:
+ if (id != WINDOWS_MUTEX_INITIALIZER) {
+ rte_thread_mutex_destroy(&m);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#295: FILE: lib/eal/windows/rte_thread.c:542:
+ if (mutex->mutex_id == WINDOWS_MUTEX_INITIALIZER) {
+ goto cleanup;
+ }
total: 4 errors, 5 warnings, 211 lines checked
More information about the test-report
mailing list