[dpdk-test-report] |WARNING| pw94440 [PATCH v3 30/62] net/cnxk: add Tx vector version for cn10k

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jun 18 12:43:31 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/94440

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#133: FILE: drivers/net/cnxk/cn10k_tx.h:43:
+#define LMT_OFF(lmt_addr, lmt_num, offset)                                     \
+	(void *)((lmt_addr) + ((lmt_num) << ROC_LMT_LINE_SIZE_LOG2) + (offset))

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#779: FILE: drivers/net/cnxk/cn10k_tx.h:1219:
+			senddesc01_w1 = vaddq_u8(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#781: FILE: drivers/net/cnxk/cn10k_tx.h:1221:
+			senddesc23_w1 = vaddq_u8(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#830: FILE: drivers/net/cnxk/cn10k_tx.h:1270:
+				__mempool_check_cookies(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#837: FILE: drivers/net/cnxk/cn10k_tx.h:1277:
+				__mempool_check_cookies(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#844: FILE: drivers/net/cnxk/cn10k_tx.h:1284:
+				__mempool_check_cookies(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#851: FILE: drivers/net/cnxk/cn10k_tx.h:1291:
+				__mempool_check_cookies(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#866: FILE: drivers/net/cnxk/cn10k_tx.h:1306:
+			__mempool_check_cookies(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#870: FILE: drivers/net/cnxk/cn10k_tx.h:1310:
+			__mempool_check_cookies(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#874: FILE: drivers/net/cnxk/cn10k_tx.h:1314:
+			__mempool_check_cookies(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#878: FILE: drivers/net/cnxk/cn10k_tx.h:1318:
+			__mempool_check_cookies(

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flags' - possible side-effects?
#990: FILE: drivers/net/cnxk/cn10k_tx_vec.c:8:
+#define T(name, f4, f3, f2, f1, f0, sz, flags)				       \
+	uint16_t __rte_noinline __rte_hot				       \
+		cn10k_nix_xmit_pkts_vec_##name(void *tx_queue,                 \
+					       struct rte_mbuf **tx_pkts,      \
+					       uint16_t pkts)                  \
+	{                                                                      \
+		uint64_t cmd[sz];                                              \
+									       \
+		/* VLAN, TSTMP, TSO is not supported by vec */                 \
+		if ((flags) & NIX_TX_OFFLOAD_VLAN_QINQ_F ||		       \
+		    (flags) & NIX_TX_OFFLOAD_TSO_F)			       \
+			return 0;                                              \
+		return cn10k_nix_xmit_pkts_vector(tx_queue, tx_pkts, pkts, cmd,\
+						  (flags));                    \
+	}

total: 1 errors, 0 warnings, 11 checks, 905 lines checked


More information about the test-report mailing list