[dpdk-test-report] |WARNING| pw94959 [PATCH v5 6/6] net/cnxk: add multi seg Tx vector routine

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Jun 29 09:46:04 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/94959

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flags' - possible side-effects?
#638: FILE: drivers/net/cnxk/cn10k_tx_vec_mseg.c:8:
+#define T(name, f5, f4, f3, f2, f1, f0, sz, flags)                             \
+	uint16_t __rte_noinline __rte_hot cn10k_nix_xmit_pkts_vec_mseg_##name( \
+		void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts)      \
+	{                                                                      \
+		uint64_t cmd[sz];                                              \
+									       \
+		/* For TSO inner checksum is a must */                         \
+		if (((flags) & NIX_TX_OFFLOAD_TSO_F) &&                        \
+		    !((flags) & NIX_TX_OFFLOAD_L3_L4_CSUM_F))                  \
+			return 0;                                              \
+		return cn10k_nix_xmit_pkts_vector(                             \
+			tx_queue, tx_pkts, pkts, cmd,                          \
+			(flags) | NIX_TX_MULTI_SEG_F);                         \
+	}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flags' - possible side-effects?
#1020: FILE: drivers/net/cnxk/cn9k_tx_vec_mseg.c:8:
+#define T(name, f5, f4, f3, f2, f1, f0, sz, flags)                             \
+	uint16_t __rte_noinline __rte_hot cn9k_nix_xmit_pkts_vec_mseg_##name(  \
+		void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts)      \
+	{                                                                      \
+		uint64_t cmd[sz];                                              \
+									       \
+		/* For TSO inner checksum is a must */                         \
+		if (((flags) & NIX_TX_OFFLOAD_TSO_F) &&                        \
+		    !((flags) & NIX_TX_OFFLOAD_L3_L4_CSUM_F))                  \
+			return 0;                                              \
+		return cn9k_nix_xmit_pkts_vector(tx_queue, tx_pkts, pkts, cmd, \
+						 (flags) |                     \
+							 NIX_TX_MULTI_SEG_F);  \
+	}

total: 0 errors, 0 warnings, 2 checks, 911 lines checked


More information about the test-report mailing list