[dpdk-test-report] |WARNING| pw89176 [PATCH v3 1/8] common/sfc_efx/base: add base virtio support for vDPA

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Mar 16 07:17:11 CET 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89176

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_t *' should also have an identifier name
#235: FILE: drivers/common/sfc_efx/base/efx_impl.h:314:
+	efx_rc_t	(*evo_virtio_qstart)(efx_virtio_vq_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_cfg_t *' should also have an identifier name
#235: FILE: drivers/common/sfc_efx/base/efx_impl.h:314:
+	efx_rc_t	(*evo_virtio_qstart)(efx_virtio_vq_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_dyncfg_t *' should also have an identifier name
#235: FILE: drivers/common/sfc_efx/base/efx_impl.h:314:
+	efx_rc_t	(*evo_virtio_qstart)(efx_virtio_vq_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_t *' should also have an identifier name
#238: FILE: drivers/common/sfc_efx/base/efx_impl.h:317:
+	efx_rc_t	(*evo_virtio_qstop)(efx_virtio_vq_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_dyncfg_t *' should also have an identifier name
#238: FILE: drivers/common/sfc_efx/base/efx_impl.h:317:
+	efx_rc_t	(*evo_virtio_qstop)(efx_virtio_vq_t *,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#335: FILE: drivers/common/sfc_efx/base/efx_virtio.c:45:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#343: FILE: drivers/common/sfc_efx/base/efx_virtio.c:53:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#371: FILE: drivers/common/sfc_efx/base/efx_virtio.c:81:
+	EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (efx_virtio_vq_t), evvp);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#383: FILE: drivers/common/sfc_efx/base/efx_virtio.c:93:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#388: FILE: drivers/common/sfc_efx/base/efx_virtio.c:98:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#416: FILE: drivers/common/sfc_efx/base/efx_virtio.c:126:
+	if ((rc = evop->evo_virtio_qstart(evvp, evvcp, evvdp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#423: FILE: drivers/common/sfc_efx/base/efx_virtio.c:133:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#434: FILE: drivers/common/sfc_efx/base/efx_virtio.c:144:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#468: FILE: drivers/common/sfc_efx/base/efx_virtio.c:178:
+	if ((rc = evop->evo_virtio_qstop(evvp, evvdp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#484: FILE: drivers/common/sfc_efx/base/efx_virtio.c:194:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#502: FILE: drivers/common/sfc_efx/base/efx_virtio.c:212:
+		EFSYS_KMEM_FREE(enp->en_esip, sizeof (efx_virtio_vq_t), evvp);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#684: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:124:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#695: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:135:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#747: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:187:
+	return (rc);

total: 12 errors, 7 warnings, 636 lines checked


More information about the test-report mailing list