[dpdk-test-report] |WARNING| pw89196 [PATCH v4 2/8] common/sfc_efx/base: add API to get VirtQ doorbell offset

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Mar 16 09:59:44 CET 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89196

_coding style issues_


WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#92: FILE: drivers/common/sfc_efx/base/efx.h:4488:
+	__out		uint32_t *offsetp);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_t *' should also have an identifier name
#105: FILE: drivers/common/sfc_efx/base/efx_impl.h:319:
+	efx_rc_t	(*evo_get_doorbell_offset)(efx_virtio_vq_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t *' should also have an identifier name
#105: FILE: drivers/common/sfc_efx/base/efx_impl.h:319:
+	efx_rc_t	(*evo_get_doorbell_offset)(efx_virtio_vq_t *,

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#129: FILE: drivers/common/sfc_efx/base/efx_virtio.c:220:
+	__out		uint32_t *offsetp)

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#135: FILE: drivers/common/sfc_efx/base/efx_virtio.c:226:
+	if ((evvp == NULL) || (offsetp == NULL)) {

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#151: FILE: drivers/common/sfc_efx/base/efx_virtio.c:242:
+	if ((rc = evop->evo_get_doorbell_offset(evvp, offsetp)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#151: FILE: drivers/common/sfc_efx/base/efx_virtio.c:242:
+	if ((rc = evop->evo_get_doorbell_offset(evvp, offsetp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#154: FILE: drivers/common/sfc_efx/base/efx_virtio.c:245:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#163: FILE: drivers/common/sfc_efx/base/efx_virtio.c:254:
+	return (rc);

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#179: FILE: drivers/common/sfc_efx/base/rhead_impl.h:499:
+	__out				uint32_t *offsetp);

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#195: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:193:
+	__out		uint32_t *offsetp)

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#246: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:244:
+			*offsetp = MCDI_OUT_DWORD(req,

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#249: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:247:
+			*offsetp = MCDI_OUT_DWORD(req,

WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#260: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:258:
+		*offsetp = MCDI_OUT_DWORD(req,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#282: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:280:
+	return (rc);

total: 4 errors, 11 warnings, 186 lines checked


More information about the test-report mailing list