[dpdk-test-report] |WARNING| pw89199 [PATCH v4 4/8] common/sfc_efx/base: add support to get virtio features

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Mar 16 09:59:53 CET 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89199

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#113: FILE: drivers/common/sfc_efx/base/efx_impl.h:321:
+	efx_rc_t	(*evo_get_features)(efx_nic_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_device_type_t' should also have an identifier name
#113: FILE: drivers/common/sfc_efx/base/efx_impl.h:321:
+	efx_rc_t	(*evo_get_features)(efx_nic_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t *' should also have an identifier name
#113: FILE: drivers/common/sfc_efx/base/efx_impl.h:321:
+	efx_rc_t	(*evo_get_features)(efx_nic_t *,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#161: FILE: drivers/common/sfc_efx/base/efx_virtio.c:285:
+	if ((rc = evop->evo_get_features(enp, type, featuresp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#164: FILE: drivers/common/sfc_efx/base/efx_virtio.c:288:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#175: FILE: drivers/common/sfc_efx/base/efx_virtio.c:299:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#247: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:325:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#254: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:332:
+	return (rc);

total: 5 errors, 3 warnings, 158 lines checked


More information about the test-report mailing list