[dpdk-test-report] |WARNING| pw89419 [PATCH 1/3] Add EAL threads API

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89419

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#248: FILE: lib/librte_eal/common/rte_thread.c:136:
+		  const rte_thread_attr_t *thread_attr, void *(*thread_func) (void*),

WARNING:TYPO_SPELLING: 'intialized' may be misspelled - perhaps 'initialized'?
#280: FILE: lib/librte_eal/common/rte_thread.c:168:
+		 * be intialized to 0. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#280: FILE: lib/librte_eal/common/rte_thread.c:168:
+		 * be intialized to 0. */

WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#298: FILE: lib/librte_eal/common/rte_thread.c:186:
+		ret = pthread_attr_setaffinity_np(attrp, sizeof(thread_attr->cpuset), &thread_attr->cpuset);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#312: FILE: lib/librte_eal/common/rte_thread.c:200:
+	if (attrp != NULL) {
+		pthread_attr_destroy(&attr);
+	}

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#323: FILE: lib/librte_eal/common/rte_thread.c:211:
+	void **pres = NULL;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#325: FILE: lib/librte_eal/common/rte_thread.c:213:
+	if (value_ptr != NULL) {
+		pres = &res;
+	}

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#326: FILE: lib/librte_eal/common/rte_thread.c:214:
+		pres = &res;

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#329: FILE: lib/librte_eal/common/rte_thread.c:217:
+	ret = pthread_join(thread_id, pres);

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#335: FILE: lib/librte_eal/common/rte_thread.c:223:
+	if (pres != NULL) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#335: FILE: lib/librte_eal/common/rte_thread.c:223:
+	if (pres != NULL) {
+		*value_ptr = *(int*)(*pres);
+	}

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#336: FILE: lib/librte_eal/common/rte_thread.c:224:
+		*value_ptr = *(int*)(*pres);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#336: FILE: lib/librte_eal/common/rte_thread.c:224:
+		*value_ptr = *(int*)(*pres);

ERROR:OPEN_BRACE: open brace '{' following enum go on the same line
#475: FILE: lib/librte_eal/include/rte_thread.h:31:
+enum rte_thread_priority
+{

ERROR:OPEN_BRACE: open brace '{' following struct go on the same line
#484: FILE: lib/librte_eal/include/rte_thread.h:40:
+typedef struct
+{

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#664: FILE: lib/librte_eal/include/rte_thread.h:220:
+		      void *(*thread_func) (void*), void *args);

WARNING:SPACING: Unnecessary space before function pointer arguments
#664: FILE: lib/librte_eal/include/rte_thread.h:220:
+		      void *(*thread_func) (void*), void *args);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#939: FILE: lib/librte_eal/windows/eal_lcore.c:123:
+		if (socket_id == RTE_DIM(cpu_map.sockets)) {
+			return true;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#951: FILE: lib/librte_eal/windows/eal_lcore.c:135:
+		if (cpu_map.lcore_count == RTE_DIM(cpu_map.lcores)) {
+			return true;
+		}

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#1445: FILE: lib/librte_eal/windows/rte_thread.c:326:
+		  const rte_thread_attr_t *thread_attr, void *(*thread_func) (void*),

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1452: FILE: lib/librte_eal/windows/rte_thread.c:333:
+	thread_handle = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)thread_func, args, 0, thread_id);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#1461: FILE: lib/librte_eal/windows/rte_thread.c:342:
+			ret = rte_convert_cpuset_to_affinity(&thread_attr->cpuset, &thread_affinity);

WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#1635: FILE: lib/librte_eal/windows/rte_thread.c:514:
+		return rte_thread_translate_win32_error(GetLastError());;

total: 6 errors, 17 warnings, 1551 lines checked
Warning in lib/librte_eal/windows/eal_lcore.c:
Declaring a variable inside for()