[dpdk-test-report] |WARNING| pw97853 [PATCH 3/5] app/dumpcap: add new packet capture application

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 3 02:49:07 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97853

_coding style issues_


WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'autostop', this function's name, in a string
#272: FILE: app/dumpcap/main.c:172:
+			 "Unknown autostop parameter \"%s\"
", opt);

WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#598: FILE: app/dumpcap/main.c:498:
+	const char *args[] = {

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#623: FILE: app/dumpcap/main.c:523:
+	struct rte_ring *pring;

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#637: FILE: app/dumpcap/main.c:537:
+	pring = rte_ring_lookup(RING_NAME);

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#638: FILE: app/dumpcap/main.c:538:
+	if (pring == NULL) {

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#639: FILE: app/dumpcap/main.c:539:
+		pring = rte_ring_create(RING_NAME, ring_size,

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#641: FILE: app/dumpcap/main.c:541:
+		if (pring == NULL)

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#645: FILE: app/dumpcap/main.c:545:
+	return pring;

WARNING:TYPO_SPELLING: 'CREAT' may be misspelled - perhaps 'CREATE'?
#705: FILE: app/dumpcap/main.c:605:
+		fd = open(output_name, O_WRONLY | O_CREAT, mode);

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#725: FILE: app/dumpcap/main.c:625:
+		return pcapng;
+	} else {

total: 0 errors, 10 warnings, 847 lines checked


More information about the test-report mailing list