[dpdk-test-report] |WARNING| pw100107 [PATCH 1/3] security: rework session framework

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Sep 30 16:52:03 CEST 2021
Previous message (by thread): [dpdk-test-report] (Testing) |FAILURE| pw(99838) sid(19202) job(PER_PATCH_BUILD8211) [v2] net/vhost: merge vhost stats loop in vhost Tx/Rx
Next message (by thread): [dpdk-test-report] |SUCCESS| pw100108 [PATCH 2/3] drivers/net: temporary disable ixgbe and txgbe
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/100107

_coding style issues_


WARNING:TYPO_SPELLING: 'unnecesarily' may be misspelled - perhaps 'unnecessarily'?
#86: 
unnecesarily use 2 mempool objects for a single session.

ERROR:C99_COMMENTS: do not use C99 // comments
#323: FILE: app/test/test_security.c:258:
+//	struct rte_mempool *priv_mp;

ERROR:C99_COMMENTS: do not use C99 // comments
#338: FILE: app/test/test_security.c:270:
+//		struct rte_mempool *priv_mp)

ERROR:C99_COMMENTS: do not use C99 // comments
#342: FILE: app/test/test_security.c:272:
+//	void *sess_priv;

ERROR:C99_COMMENTS: do not use C99 // comments
#343: FILE: app/test/test_security.c:273:
+//	int ret;

ERROR:C99_COMMENTS: do not use C99 // comments
#350: FILE: app/test/test_security.c:279:
+//	MOCK_TEST_ASSERT_POINTER_PARAMETER(mock_session_create_exp, priv_mp);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 0)
#352: FILE: app/test/test_security.c:281:
 	if (mock_session_create_exp.ret == 0) {
+//		ret = rte_mempool_get(priv_mp, &sess_priv);

ERROR:C99_COMMENTS: do not use C99 // comments
#356: FILE: app/test/test_security.c:282:
+//		ret = rte_mempool_get(priv_mp, &sess_priv);

ERROR:C99_COMMENTS: do not use C99 // comments
#357: FILE: app/test/test_security.c:283:
+//		TEST_ASSERT_EQUAL(0, ret,

ERROR:C99_COMMENTS: do not use C99 // comments
#358: FILE: app/test/test_security.c:284:
+//			"priv mempool does not have enough objects");

ERROR:C99_COMMENTS: do not use C99 // comments
#361: FILE: app/test/test_security.c:286:
+//		set_sec_session_private_data(sess, sess_priv);

ERROR:C99_COMMENTS: do not use C99 // comments
#497: FILE: app/test/test_security.c:580:
+//	ts_params->session_priv_mpool = rte_mempool_create(

ERROR:C99_COMMENTS: do not use C99 // comments
#498: FILE: app/test/test_security.c:581:
+//			SECURITY_TEST_PRIV_MEMPOOL_NAME,

ERROR:C99_COMMENTS: do not use C99 // comments
#499: FILE: app/test/test_security.c:582:
+//			SECURITY_TEST_MEMPOOL_SIZE,

ERROR:C99_COMMENTS: do not use C99 // comments
#500: FILE: app/test/test_security.c:583:
+//			SECURITY_TEST_SESSION_PRIV_OBJ_SZ,

ERROR:C99_COMMENTS: do not use C99 // comments
#501: FILE: app/test/test_security.c:584:
+//			0, 0, NULL, NULL, NULL, NULL,

ERROR:C99_COMMENTS: do not use C99 // comments
#502: FILE: app/test/test_security.c:585:
+//			SOCKET_ID_ANY, 0);

ERROR:C99_COMMENTS: do not use C99 // comments
#503: FILE: app/test/test_security.c:586:
+//	if (ts_params->session_priv_mpool == NULL) {

ERROR:C99_COMMENTS: do not use C99 // comments
#504: FILE: app/test/test_security.c:587:
+//		RTE_LOG(ERR, USER1, "TestCase %s() line %d failed (null): "

ERROR:C99_COMMENTS: do not use C99 // comments
#505: FILE: app/test/test_security.c:588:
+//				"Cannot create priv mempool %s
",

ERROR:C99_COMMENTS: do not use C99 // comments
#506: FILE: app/test/test_security.c:589:
+//				__func__, __LINE__, rte_strerror(rte_errno));

ERROR:C99_COMMENTS: do not use C99 // comments
#507: FILE: app/test/test_security.c:590:
+//		rte_mempool_free(ts_params->session_mpool);

ERROR:C99_COMMENTS: do not use C99 // comments
#508: FILE: app/test/test_security.c:591:
+//		ts_params->session_mpool = NULL;

ERROR:C99_COMMENTS: do not use C99 // comments
#509: FILE: app/test/test_security.c:592:
+//		return TEST_FAILED;

ERROR:C99_COMMENTS: do not use C99 // comments
#510: FILE: app/test/test_security.c:593:
+//	}

ERROR:C99_COMMENTS: do not use C99 // comments
#670: FILE: app/test/test_security.c:856:
+//static int

ERROR:C99_COMMENTS: do not use C99 // comments
#671: FILE: app/test/test_security.c:857:
+//test_session_create_inv_sess_priv_mempool(void)

ERROR:C99_COMMENTS: do not use C99 // comments
#672: FILE: app/test/test_security.c:858:
+//{

ERROR:C99_COMMENTS: do not use C99 // comments
#673: FILE: app/test/test_security.c:859:
+//	struct security_unittest_params *ut_params = &unittest_params;

ERROR:C99_COMMENTS: do not use C99 // comments
#674: FILE: app/test/test_security.c:860:
+//	struct security_testsuite_params *ts_params = &testsuite_params;

ERROR:C99_COMMENTS: do not use C99 // comments
#675: FILE: app/test/test_security.c:861:
+//	struct rte_security_session *sess;

ERROR:C99_COMMENTS: do not use C99 // comments
#676: FILE: app/test/test_security.c:862:
+//

ERROR:C99_COMMENTS: do not use C99 // comments
#677: FILE: app/test/test_security.c:863:
+//	sess = rte_security_session_create(&ut_params->ctx, &ut_params->conf,

ERROR:C99_COMMENTS: do not use C99 // comments
#678: FILE: app/test/test_security.c:864:
+//			ts_params->session_mpool, NULL);

ERROR:C99_COMMENTS: do not use C99 // comments
#679: FILE: app/test/test_security.c:865:
+//	TEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_create,

ERROR:C99_COMMENTS: do not use C99 // comments
#680: FILE: app/test/test_security.c:866:
+//			sess, NULL, "%p");

ERROR:C99_COMMENTS: do not use C99 // comments
#681: FILE: app/test/test_security.c:867:
+//	TEST_ASSERT_MOCK_CALLS(mock_session_create_exp, 0);

ERROR:C99_COMMENTS: do not use C99 // comments
#682: FILE: app/test/test_security.c:868:
+//	TEST_ASSERT_MEMPOOL_USAGE(0);

ERROR:C99_COMMENTS: do not use C99 // comments
#683: FILE: app/test/test_security.c:869:
+//	TEST_ASSERT_PRIV_MP_USAGE(0);

ERROR:C99_COMMENTS: do not use C99 // comments
#684: FILE: app/test/test_security.c:870:
+//	TEST_ASSERT_SESSION_COUNT(0);

ERROR:C99_COMMENTS: do not use C99 // comments
#685: FILE: app/test/test_security.c:871:
+//

ERROR:C99_COMMENTS: do not use C99 // comments
#686: FILE: app/test/test_security.c:872:
+//	return TEST_SUCCESS;

ERROR:C99_COMMENTS: do not use C99 // comments
#687: FILE: app/test/test_security.c:873:
+//}

ERROR:C99_COMMENTS: do not use C99 // comments
#698: FILE: app/test/test_security.c:884:
+//	struct rte_security_session *tmp[SECURITY_TEST_MEMPOOL_SIZE];

ERROR:C99_COMMENTS: do not use C99 // comments
#713: FILE: app/test/test_security.c:896:
+//		ret = rte_mempool_get(ts_params->session_priv_mpool,

ERROR:C99_COMMENTS: do not use C99 // comments
#714: FILE: app/test/test_security.c:897:
+//				(void **)(&tmp1[i]));

ERROR:C99_COMMENTS: do not use C99 // comments
#715: FILE: app/test/test_security.c:898:
+//		TEST_ASSERT_EQUAL(0, ret,

ERROR:C99_COMMENTS: do not use C99 // comments
#716: FILE: app/test/test_security.c:899:
+//				"Expect getting %d object from priv mempool"

ERROR:C99_COMMENTS: do not use C99 // comments
#717: FILE: app/test/test_security.c:900:
+//				" to succeed", i);

ERROR:C99_COMMENTS: do not use C99 // comments
#721: FILE: app/test/test_security.c:903:
+//	TEST_ASSERT_PRIV_MP_USAGE(SECURITY_TEST_MEMPOOL_SIZE);

ERROR:C99_COMMENTS: do not use C99 // comments
#727: FILE: app/test/test_security.c:907:
+//			ts_params->session_priv_mpool);

ERROR:C99_COMMENTS: do not use C99 // comments
#733: FILE: app/test/test_security.c:912:
+//	TEST_ASSERT_PRIV_MP_USAGE(SECURITY_TEST_MEMPOOL_SIZE);

ERROR:C99_COMMENTS: do not use C99 // comments
#742: FILE: app/test/test_security.c:919:
+//		rte_mempool_put(ts_params->session_priv_mpool,

ERROR:C99_COMMENTS: do not use C99 // comments
#743: FILE: app/test/test_security.c:920:
+//				(tmp1[i]));

ERROR:C99_COMMENTS: do not use C99 // comments
#747: FILE: app/test/test_security.c:923:
+//	TEST_ASSERT_PRIV_MP_USAGE(0);

ERROR:C99_COMMENTS: do not use C99 // comments
#762: FILE: app/test/test_security.c:942:
+//	mock_session_create_exp.priv_mp = ts_params->session_priv_mpool;

ERROR:C99_COMMENTS: do not use C99 // comments
#769: FILE: app/test/test_security.c:947:
+//			ts_params->session_priv_mpool);

ERROR:C99_COMMENTS: do not use C99 // comments
#775: FILE: app/test/test_security.c:952:
+//	TEST_ASSERT_PRIV_MP_USAGE(0);

ERROR:C99_COMMENTS: do not use C99 // comments
#790: FILE: app/test/test_security.c:971:
+//	mock_session_create_exp.priv_mp = ts_params->session_priv_mpool;

ERROR:C99_COMMENTS: do not use C99 // comments
#797: FILE: app/test/test_security.c:976:
+//			ts_params->session_priv_mpool);

ERROR:C99_COMMENTS: do not use C99 // comments
#806: FILE: app/test/test_security.c:985:
+//	TEST_ASSERT_PRIV_MP_USAGE(1);

ERROR:C99_COMMENTS: do not use C99 // comments
#912: FILE: app/test/test_security.c:2465:
+//		TEST_CASE_ST(ut_setup, ut_teardown,

ERROR:C99_COMMENTS: do not use C99 // comments
#913: FILE: app/test/test_security.c:2466:
+//				test_session_create_inv_sess_priv_mempool),

ERROR:C99_COMMENTS: do not use C99 // comments
#1494: FILE: drivers/crypto/dpaa_sec/dpaa_sec.c:3119:
+//	void *sess_private_data = sess;

ERROR:C99_COMMENTS: do not use C99 // comments
#1502: FILE: drivers/crypto/dpaa_sec/dpaa_sec.c:3123:
+//	if (rte_mempool_get(mempool, &sess_private_data)) {

ERROR:C99_COMMENTS: do not use C99 // comments
#1503: FILE: drivers/crypto/dpaa_sec/dpaa_sec.c:3124:
+//		DPAA_SEC_ERR("Couldn't get object from session mempool");

ERROR:C99_COMMENTS: do not use C99 // comments
#1504: FILE: drivers/crypto/dpaa_sec/dpaa_sec.c:3125:
+//		return -ENOMEM;

ERROR:C99_COMMENTS: do not use C99 // comments
#1505: FILE: drivers/crypto/dpaa_sec/dpaa_sec.c:3126:
+//	}

ERROR:C99_COMMENTS: do not use C99 // comments
#1525: FILE: drivers/crypto/dpaa_sec/dpaa_sec.c:3143:
+//		rte_mempool_put(mempool, sess_private_data);

ERROR:C99_COMMENTS: do not use C99 // comments
#1530: FILE: drivers/crypto/dpaa_sec/dpaa_sec.c:3147:
+//	set_sec_session_private_data(sess, sess_private_data);

total: 68 errors, 2 warnings, 2142 lines checked
Previous message (by thread): [dpdk-test-report] (Testing) |FAILURE| pw(99838) sid(19202) job(PER_PATCH_BUILD8211) [v2] net/vhost: merge vhost stats loop in vhost Tx/Rx
Next message (by thread): [dpdk-test-report] |SUCCESS| pw100108 [PATCH 2/3] drivers/net: temporary disable ixgbe and txgbe
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list