|WARNING| pw108524 [PATCH] dpdk: show dev basic info

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 4 02:24:53 CET 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/108524

_coding style issues_


ERROR:SPACING: space required after that close brace '}'
#169: FILE: app/proc-info/main.c:173:
+}eth_speed_table[] = {

ERROR:SPACING: space prohibited after that open parenthesis '('
#220: FILE: app/proc-info/main.c:795:
+	printf( "	  -- maximum number of MAC addresses: %u
"

ERROR:SPACING: space prohibited after that open parenthesis '('
#272: FILE: app/proc-info/main.c:847:
+		printf( "	  -- RSS disabled");

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(eth_speed_table)
#291: FILE: app/proc-info/main.c:866:
+	int size = sizeof(eth_speed_table) / sizeof(eth_speed_table[0]);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#299: FILE: app/proc-info/main.c:874:
+	if (!(speed_capa & ETH_LINK_SPEED_FIXED)) {
+		printf("auto");
+	}

ERROR:SPACING: space prohibited after that open parenthesis '('
#318: FILE: app/proc-info/main.c:893:
+		printf( "	  -- Rx burst mode: %s%s
"

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#488: FILE: drivers/net/hns3/hns3_ethdev_dump.c:18:
+	static const char *state_name[] = {

ERROR:TRAILING_WHITESPACE: trailing whitespace
#566: FILE: drivers/net/hns3/hns3_ethdev_dump.c:96:
+^I};^I$

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#578: FILE: drivers/net/hns3/hns3_ethdev_dump.c:108:
+	static const char *tuple_name[] = {

WARNING:TYPO_SPELLING: '2st' may be misspelled - perhaps '2nd'?
#582: FILE: drivers/net/hns3/hns3_ethdev_dump.c:112:
+		"outer_vlan_2st_tag",

ERROR:TRAILING_WHITESPACE: trailing whitespace
#834: FILE: drivers/net/hns3/hns3_ethdev_dump.c:364:
+}^I^I^I$

ERROR:SPACING: space required after that ',' (ctx:VxV)
#900: FILE: drivers/net/hns3/hns3_ethdev_dump.c:430:
+	fprintf(file,"  - Rx/Tx Queue Info:
");
 	            ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#1096: FILE: drivers/net/hns3/hns3_ethdev_dump.c:626:
+	fprintf(file,"  - VLAN Config Info:
");
 	            ^

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1109: FILE: drivers/net/hns3/hns3_ethdev_dump.c:639:
+^Iget_port_pvid_info(file, hw);^I$

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#1125: FILE: drivers/net/hns3/hns3_ethdev_dump.c:655:
+			"    id=%u reference_count=%u peak_rate=%"PRIu64"Bps
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1125: FILE: drivers/net/hns3/hns3_ethdev_dump.c:655:
+			"    id=%u reference_count=%u peak_rate=%"PRIu64"Bps
",

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1139: FILE: drivers/net/hns3/hns3_ethdev_dump.c:669:
+		"  port_node: 
"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1157: FILE: drivers/net/hns3/hns3_ethdev_dump.c:687:
+	fprintf(file, "  tc_node: 
");

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1224: FILE: drivers/net/hns3/hns3_ethdev_dump.c:754:
+		"  queue_node: 
"

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1377: FILE: drivers/net/hns3/hns3_ethdev_dump.c:907:
+^I^Ireturn 0;^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1382: FILE: drivers/net/hns3/hns3_ethdev_dump.c:912:
+^Iget_fdir_basic_info(file, &hns->pf);^I$

total: 11 errors, 8 warnings, 1365 lines checked


More information about the test-report mailing list