|WARNING| pw115805 [Patch v7 01/18] net/mana: add basic driver, build environment and doc

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/115805

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#251: FILE: drivers/net/mana/mana.c:33:
+#define MKSTR(name, ...) \
+	int mkstr_size_##name = snprintf(NULL, 0, "" __VA_ARGS__); \
+	char name[mkstr_size_##name + 1]; \
+	\
+	memset(name, 0, mkstr_size_##name + 1); \
+	snprintf(name, sizeof(name), "" __VA_ARGS__)

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#285: FILE: drivers/net/mana/mana.c:67:
+static const char *mana_init_args[] = {

CHECK:CAMELCASE: Avoid CamelCase: <SCNx32>
#429: FILE: drivers/net/mana/mana.c:211:
+			   "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 "
",

CHECK:CAMELCASE: Avoid CamelCase: <SCNx8>
#429: FILE: drivers/net/mana/mana.c:211:
+			   "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 "
",

total: 0 errors, 1 warnings, 3 checks, 1297 lines checked