|WARNING| pw116403 [PATCH] net/ice: support traffic to original DCF port

[dpdklab at iol.unh.edu]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/116403

_apply patch failure_

Submitter: Zhichao Zeng <zhichaox.zeng at intel.com>
Date: Saturday, September 17 2022 01:49:10 
Applied on: CommitID:f8f6b1c1744e12d8d6877464a613acd1231db1a1
Apply patch set 116403 failed:

Checking patch doc/guides/nics/features/ice.ini...
error: while searching for:
queue                = Y
rss                  = Y
represented_port     = Y

error: patch failed: doc/guides/nics/features/ice.ini:82
Checking patch drivers/net/ice/ice_switch_filter.c...
error: while searching for:
				RTE_FLOW_ACTION_TYPE_END; action++) {
		action_type = action->type;
		switch (action_type) {
		case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT:
			rule_info->sw_act.fltr_act = ICE_FWD_TO_VSI;
			act_ethdev = action->conf;

error: patch failed: drivers/net/ice/ice_switch_filter.c:1628
error: while searching for:
		case RTE_FLOW_ACTION_TYPE_QUEUE:
		case RTE_FLOW_ACTION_TYPE_DROP:
		case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT:
			actions_num++;
			break;
		case RTE_FLOW_ACTION_TYPE_VOID:

error: patch failed: drivers/net/ice/ice_switch_filter.c:1799
Applying patch doc/guides/nics/features/ice.ini with 1 reject...
Rejected hunk #1.
Applying patch drivers/net/ice/ice_switch_filter.c with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
diff a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini	(rejected hunks)
@@ -82,3 +82,4 @@ passthru             = Y
 queue                = Y
 rss                  = Y
 represented_port     = Y
+port_representor     = Y
diff a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c	(rejected hunks)
@@ -1628,6 +1628,30 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,
 				RTE_FLOW_ACTION_TYPE_END; action++) {
 		action_type = action->type;
 		switch (action_type) {
+		case RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR:
+			rule_info->sw_act.fltr_act = ICE_FWD_TO_VSI;
+			act_ethdev = action->conf;
+
+			if (!rte_eth_dev_is_valid_port(act_ethdev->port_id))
+				goto invalid_port_id;
+
+			/* For traffic to original DCF port */
+			rule_port_id = ad->parent.pf.dev_data->port_id;
+
+			if (rule_port_id != act_ethdev->port_id)
+				goto invalid_port_id;
+
+			rule_info->sw_act.vsi_handle = 0;
+
+			break;
+
+invalid_port_id:
+			rte_flow_error_set(error,
+						EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
+						actions,
+						"Invalid port_id");
+			return -rte_errno;
+
 		case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT:
 			rule_info->sw_act.fltr_act = ICE_FWD_TO_VSI;
 			act_ethdev = action->conf;
@@ -1799,6 +1823,7 @@ ice_switch_check_action(const struct rte_flow_action *actions,
 		case RTE_FLOW_ACTION_TYPE_QUEUE:
 		case RTE_FLOW_ACTION_TYPE_DROP:
 		case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT:
+		case RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR:
 			actions_num++;
 			break;
 		case RTE_FLOW_ACTION_TYPE_VOID:

https://lab.dpdk.org/results/dashboard/patchsets/23527/

UNH-IOL DPDK Community Lab