|WARNING| pw116750 [PATCH 11/27] net/mlx5: add HW steering counter action

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 23 16:49:15 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/116750

_coding style issues_


WARNING:BAD_SIGN_OFF: Duplicate signature
#177: 
Signed-off-by: Xiaoyu Min <jackmin at nvidia.com>

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1185: FILE: drivers/net/mlx5/mlx5_flow_meter.c:109:
+	if (priv->sh->config.dv_esw_en && priv->master)

WARNING:REPEATED_WORD: Possible repeated word: 'the'
#1238: FILE: drivers/net/mlx5/mlx5_hws_cnt.c:37:
+	 * In the end, user fetch the the counter from minimal to the maximum.

WARNING:TYPO_SPELLING: 'alloced' may be misspelled - perhaps 'allocated'?
#1500: FILE: drivers/net/mlx5/mlx5_hws_cnt.c:299:
+	uint32_t idx, alloced = 0;

WARNING:TYPO_SPELLING: 'alloced' may be misspelled - perhaps 'allocated'?
#1526: FILE: drivers/net/mlx5/mlx5_hws_cnt.c:325:
+	alloced = cpool->dcs_mng.dcs[0].batch_sz;

WARNING:TYPO_SPELLING: 'alloced' may be misspelled - perhaps 'allocated'?
#1537: FILE: drivers/net/mlx5/mlx5_hws_cnt.c:336:
+			cpool->dcs_mng.dcs[idx].iidx = alloced;

WARNING:TYPO_SPELLING: 'alloced' may be misspelled - perhaps 'allocated'?
#1538: FILE: drivers/net/mlx5/mlx5_hws_cnt.c:337:
+			alloced += cpool->dcs_mng.dcs[idx].batch_sz;

CHECK:CAMELCASE: Avoid CamelCase: <PRIu32>
#1545: FILE: drivers/net/mlx5/mlx5_hws_cnt.c:344:
+		"Cannot alloc device counter, allocated[%" PRIu32 "] request[%" PRIu32 "]",

WARNING:TYPO_SPELLING: 'alloced' may be misspelled - perhaps 'allocated'?
#1546: FILE: drivers/net/mlx5/mlx5_hws_cnt.c:345:
+		alloced, cnt_num);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1583: FILE: drivers/net/mlx5/mlx5_hws_cnt.c:382:
+	if (priv->sh->config.dv_esw_en && priv->master)

total: 0 errors, 9 warnings, 1 checks, 1977 lines checked
Warning in drivers/net/mlx5/mlx5_hws_cnt.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t


More information about the test-report mailing list