|WARNING| pw124802 [PATCH v2] log: add timestamp for log

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/124802

_coding style issues_

Must be a reply to the first patch (--in-reply-to).


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#84: FILE: lib/eal/common/eal_common_log.c:487:
+    struct tm *info;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#85: FILE: lib/eal/common/eal_common_log.c:488:
+    char date[24];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#86: FILE: lib/eal/common/eal_common_log.c:489:
+    struct timespec ts;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#87: FILE: lib/eal/common/eal_common_log.c:490:
+    long usec;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#89: FILE: lib/eal/common/eal_common_log.c:492:
+    clock_gettime(CLOCK_REALTIME, &ts);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#90: FILE: lib/eal/common/eal_common_log.c:493:
+    info = localtime(&ts.tv_sec);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#91: FILE: lib/eal/common/eal_common_log.c:494:
+    usec = ts.tv_nsec / 1000;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: lib/eal/common/eal_common_log.c:495:
+    if (info == NULL) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#93: FILE: lib/eal/common/eal_common_log.c:496:
+        snprintf(buf, buf_size, "[%s.%06ld] ", "unknown date", usec);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#93: FILE: lib/eal/common/eal_common_log.c:496:
+        snprintf(buf, buf_size, "[%s.%06ld] ", "unknown date", usec);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#94: FILE: lib/eal/common/eal_common_log.c:497:
+        return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#94: FILE: lib/eal/common/eal_common_log.c:497:
+        return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#95: FILE: lib/eal/common/eal_common_log.c:498:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#97: FILE: lib/eal/common/eal_common_log.c:500:
+    strftime(date, sizeof(date), "%Y-%m-%d %H:%M:%S", info);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#98: FILE: lib/eal/common/eal_common_log.c:501:
+    snprintf(buf, buf_size, "[%s.%06ld] ", date, usec);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#108: FILE: lib/eal/common/eal_common_log.c:513:
+        char timestamp[64];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#108: FILE: lib/eal/common/eal_common_log.c:513:
+        char timestamp[64];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#118: FILE: lib/eal/common/eal_common_log.c:523:
+        rte_log_get_timestamp_prefix(timestamp, sizeof(timestamp));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#118: FILE: lib/eal/common/eal_common_log.c:523:
+        rte_log_get_timestamp_prefix(timestamp, sizeof(timestamp));$

ERROR:CODE_INDENT: code indent should use tabs where possible
#119: FILE: lib/eal/common/eal_common_log.c:524:
+        fprintf(f, "%s ", timestamp);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#119: FILE: lib/eal/common/eal_common_log.c:524:
+        fprintf(f, "%s ", timestamp);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#120: FILE: lib/eal/common/eal_common_log.c:525:
+        ret = vfprintf(f, format, ap);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#120: FILE: lib/eal/common/eal_common_log.c:525:
+        ret = vfprintf(f, format, ap);$

total: 6 errors, 17 warnings, 45 lines checked
zhipeng Lu <luzhipeng at cestc.cn> is unknown, please fix the commit message or update .mailmap.
zhipeng Lu <luzhipeng at cestc.cn> is unknown, please fix the commit message or update .mailmap.