|WARNING| pw125005 [PATCH 15/16] net/hns3: reimplement hash flow function

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 10 10:38:44 CET 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/125005

_coding style issues_


WARNING:TYPO_SPELLING: 'mulitiple' may be misspelled - perhaps 'multiple'?
#58: 
Currently, hns3 driver supports setting mulitiple rte flow RSS rule,

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#76: 
[1] https://lore.kernel.org/all/DM5PR12MB46648085D7CABF1AFF2D75CDD60A9@DM5PR12MB4664.namprd12.prod.outlook.com/

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#120: FILE: drivers/net/hns3/hns3_flow.c:13:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+	do { \
+		(act) = (actions) + (index); \
+		while ((act)->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+			(index)++; \
+			(act) = (actions) + (index); \
+		} \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#120: FILE: drivers/net/hns3/hns3_flow.c:13:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+	do { \
+		(act) = (actions) + (index); \
+		while ((act)->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+			(index)++; \
+			(act) = (actions) + (index); \
+		} \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#120: FILE: drivers/net/hns3/hns3_flow.c:13:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+	do { \
+		(act) = (actions) + (index); \
+		while ((act)->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+			(index)++; \
+			(act) = (actions) + (index); \
+		} \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'item' - possible side-effects?
#129: FILE: drivers/net/hns3/hns3_flow.c:22:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \
+	do { \
+		(item) = (pattern) + (index); \
+		while ((item)->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+			(index)++; \
+			(item) = (pattern) + (index); \
+		} \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pattern' - possible side-effects?
#129: FILE: drivers/net/hns3/hns3_flow.c:22:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \
+	do { \
+		(item) = (pattern) + (index); \
+		while ((item)->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+			(index)++; \
+			(item) = (pattern) + (index); \
+		} \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#129: FILE: drivers/net/hns3/hns3_flow.c:22:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \
+	do { \
+		(item) = (pattern) + (index); \
+		while ((item)->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+			(index)++; \
+			(item) = (pattern) + (index); \
+		} \
+	} while (0)

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#619: FILE: drivers/net/hns3/hns3_flow.c:1656:
+			hns3_warn(hw, "some types in the requested RSS types (0x%" PRIx64 ") aren't supported, they are ignored.",

total: 0 errors, 2 warnings, 7 checks, 1603 lines checked


More information about the test-report mailing list