|WARNING| pw124873 [PATCH] [v3] net/mlx5: use just sufficient barrier for ARM platforms

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Sat Mar 11 10:39:00 CET 2023


Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/124873

_apply patch failure_

Submitter: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
Date: Thursday, March 09 2023 02:32:47 
Applied on: CommitID:b15d75b2872efce397d827dac78692a919358302
Apply patch set 124873 failed:

Checking patch drivers/common/mlx5/mlx5_common.h...
error: while searching for:

	if (unlikely((op_owner != (!!(idx))) || (op_code == MLX5_CQE_INVALID)))
		return MLX5_CQE_STATUS_HW_OWN;
	rte_io_rmb();
	if (unlikely(op_code == MLX5_CQE_RESP_ERR ||
		     op_code == MLX5_CQE_REQ_ERR))
		return MLX5_CQE_STATUS_ERR;

error: patch failed: drivers/common/mlx5/mlx5_common.h:203
Applying patch drivers/common/mlx5/mlx5_common.h with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h	(rejected hunks)
@@ -203,7 +203,11 @@ check_cqe(volatile struct mlx5_cqe *cqe, const uint16_t cqes_n,
 
 	if (unlikely((op_owner != (!!(idx))) || (op_code == MLX5_CQE_INVALID)))
 		return MLX5_CQE_STATUS_HW_OWN;
-	rte_io_rmb();
+	/* Prevent speculative reading of other fields in CQE until
+	 * CQE is valid.
+	 */
+	rte_atomic_thread_fence(__ATOMIC_ACQUIRE);
+
 	if (unlikely(op_code == MLX5_CQE_RESP_ERR ||
 		     op_code == MLX5_CQE_REQ_ERR))
 		return MLX5_CQE_STATUS_ERR;

https://lab.dpdk.org/results/dashboard/patchsets/25649/

UNH-IOL DPDK Community Lab


More information about the test-report mailing list