|WARNING| pw134116 [PATCH] BUILD bug hidden in SFC driver.

[dpdklab at iol.unh.edu]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/134116

_apply patch failure_

Submitter: Stephen Hemminger <stephen at networkplumber.org>
Date: Saturday, November 11 2023 16:56:34 
Applied on: CommitID:147fb8a7be4382b5b1150d74cb7f10933ddf9d78
Apply patch set 134116 failed:

Checking patch drivers/net/sfc/sfc_ef100_tx.c...
error: while searching for:
                * Make sure that the first segment does not need fragmentation
                * (split into many Tx descriptors).
                */
               RTE_BUILD_BUG_ON(SFC_EF100_TX_SEND_DESC_LEN_MAX <
                                RTE_MIN((unsigned int)EFX_MAC_PDU_MAX,
                                SFC_MBUF_SEG_LEN_MAX));
       }

       if (m->ol_flags & sfc_dp_mport_override) {

error: patch failed: drivers/net/sfc/sfc_ef100_tx.c:562
Applying patch drivers/net/sfc/sfc_ef100_tx.c with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/net/sfc/sfc_ef100_tx.c b/drivers/net/sfc/sfc_ef100_tx.c	(rejected hunks)
@@ -562,9 +562,8 @@ sfc_ef100_tx_pkt_descs_max(const struct rte_mbuf *m)
                 * Make sure that the first segment does not need fragmentation
                 * (split into many Tx descriptors).
                 */
-               RTE_BUILD_BUG_ON(SFC_EF100_TX_SEND_DESC_LEN_MAX <
-                                RTE_MIN((unsigned int)EFX_MAC_PDU_MAX,
-                                SFC_MBUF_SEG_LEN_MAX));
+               RTE_BUILD_BUG_ON(SFC_EF100_TX_SEND_DESC_LEN_MAX < EFX_MAC_PDU_MAX);
+               RTE_BUILD_BUG_ON(SFC_EF100_TX_SEND_DESC_LEN_MAX < SFC_MBUF_SEG_LEN_MAX);
        }
 
        if (m->ol_flags & sfc_dp_mport_override) {

https://lab.dpdk.org/results/dashboard/patchsets/28336/

UNH-IOL DPDK Community Lab