|WARNING| pw131825 [RFC PATCH 4/5] app: add IO proxy app using shared memory interfaces

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 22 10:20:35 CEST 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/131825

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#110: FILE: app/io-proxy/command_fns.c:15:
+extern volatile bool running_startup_script;

WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#404: FILE: app/io-proxy/datapath.c:131:
+	char *argv[] = {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#738: FILE: app/io-proxy/datapath.c:465:
+		return EEXIST;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#743: FILE: app/io-proxy/datapath.c:470:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#751: FILE: app/io-proxy/datapath.c:478:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EADDRINUSE)
#775: FILE: app/io-proxy/datapath.c:502:
+			return EADDRINUSE;

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#1005: FILE: app/io-proxy/main.c:4:
+#include <stdio.h>

total: 0 errors, 7 warnings, 966 lines checked


More information about the test-report mailing list