|WARNING| pw149383 [PATCH] app/test-flow-perf: support testing the flow table query rate

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Dec 23 09:37:34 CET 2024


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/149383

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: app/test-flow-perf/main.c:892:
+ ^I^I^I^Iquery_flag = true;$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#155: FILE: app/test-flow-perf/main.c:892:
+ ^I^I^I^Iquery_flag = true;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#155: FILE: app/test-flow-perf/main.c:892:
+ ^I^I^I^Iquery_flag = true;$

WARNING:TABSTOP: Statements should start on a tabstop
#181: FILE: app/test-flow-perf/main.c:1403:
+		 {

WARNING:TABSTOP: Statements should start on a tabstop
#185: FILE: app/test-flow-perf/main.c:1407:
+		 {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#192: FILE: app/test-flow-perf/main.c:1414:
+	if (flow_group > 0 && core_id == 0)
+		 rules_count_per_core++;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#197: FILE: app/test-flow-perf/main.c:1419:
+	for (i = 0; i < (uint32_t)rules_count_per_core; i++) {
+		 if (flows_list[i] == 0)

WARNING:TABSTOP: Statements should start on a tabstop
#198: FILE: app/test-flow-perf/main.c:1420:
+		 if (flows_list[i] == 0)

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (17, 26)
#198: FILE: app/test-flow-perf/main.c:1420:
+		 if (flows_list[i] == 0)
+			  break;

WARNING:TABSTOP: Statements should start on a tabstop
#199: FILE: app/test-flow-perf/main.c:1421:
+			  break;

WARNING:TABSTOP: Statements should start on a tabstop
#202: FILE: app/test-flow-perf/main.c:1424:
+		 if (rte_flow_query(port_id, flows_list[i],

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (17, 26)
#202: FILE: app/test-flow-perf/main.c:1424:
+		 if (rte_flow_query(port_id, flows_list[i],
[...]
+			  print_flow_error(error);

WARNING:TABSTOP: Statements should start on a tabstop
#206: FILE: app/test-flow-perf/main.c:1428:
+		 }

WARNING:TABSTOP: Statements should start on a tabstop
#214: FILE: app/test-flow-perf/main.c:1436:
+		 if (!((i + 1) % rules_batch)) {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (17, 26)
#214: FILE: app/test-flow-perf/main.c:1436:
+		 if (!((i + 1) % rules_batch)) {
+			  end_batch = rte_get_timer_cycles();

WARNING:TABSTOP: Statements should start on a tabstop
#221: FILE: app/test-flow-perf/main.c:1443:
+		 }

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#225: FILE: app/test-flow-perf/main.c:1447:
+	if (dump_iterations)
+		 print_rules_batches(cpu_time_per_batch);

total: 1 errors, 16 warnings, 210 lines checked


More information about the test-report mailing list