|WARNING| pw148197 [PATCH v6 12/17] net/r8169: implement Tx path

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/148197

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <NextHwDesCloPtr0>
#146: FILE: drivers/net/r8169/r8169_ethdev.h:78:
+	u32 NextHwDesCloPtr0;

CHECK:CAMELCASE: Avoid CamelCase: <BeginHwDesCloPtr0>
#147: FILE: drivers/net/r8169/r8169_ethdev.h:79:
+	u32 BeginHwDesCloPtr0;

CHECK:SPACING: No space is necessary after a cast
#231: FILE: drivers/net/r8169/r8169_rxtx.c:74:
+	RTE_ATOMIC(uint32_t) tx_tail;

CHECK:CAMELCASE: Avoid CamelCase: <RingEnd>
#345: FILE: drivers/net/r8169/r8169_rxtx.c:896:
+	txq->hw_ring[txq->nb_tx_desc - 1].opts1 = rte_cpu_to_le_32(RingEnd);

CHECK:CAMELCASE: Avoid CamelCase: <TxDescStartAddrLow>
#456: FILE: drivers/net/r8169/r8169_rxtx.c:1007:
+	RTL_W32(hw, TxDescStartAddrLow,

CHECK:CAMELCASE: Avoid CamelCase: <TxDescStartAddrHigh>
#458: FILE: drivers/net/r8169/r8169_rxtx.c:1009:
+	RTL_W32(hw, TxDescStartAddrHigh, ((u64)txq->hw_ring_phys_addr >> 32));

CHECK:CAMELCASE: Avoid CamelCase: <ChipCmd>
#472: FILE: drivers/net/r8169/r8169_rxtx.c:1023:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb);

CHECK:CAMELCASE: Avoid CamelCase: <CmdTxEnb>
#472: FILE: drivers/net/r8169/r8169_rxtx.c:1023:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb);

CHECK:CAMELCASE: Avoid CamelCase: <TxVlanTag>
#485: FILE: drivers/net/r8169/r8169_rxtx.c:1034:
+	       (TxVlanTag | rte_bswap16(tx_pkt->vlan_tci)) :

CHECK:CAMELCASE: Avoid CamelCase: <GiantSendv4>
#502: FILE: drivers/net/r8169/r8169_rxtx.c:1051:
+				opts[0] |= GiantSendv4;

CHECK:CAMELCASE: Avoid CamelCase: <GiantSendv6>
#504: FILE: drivers/net/r8169/r8169_rxtx.c:1053:
+				opts[0] |= GiantSendv6;

CHECK:CAMELCASE: Avoid CamelCase: <TxIPCS_C>
#524: FILE: drivers/net/r8169/r8169_rxtx.c:1073:
+		csum_cmd |= TxIPCS_C;

CHECK:CAMELCASE: Avoid CamelCase: <TxUDPCS_C>
#528: FILE: drivers/net/r8169/r8169_rxtx.c:1077:
+		csum_cmd |= TxUDPCS_C;

CHECK:CAMELCASE: Avoid CamelCase: <TxTCPCS_C>
#531: FILE: drivers/net/r8169/r8169_rxtx.c:1080:
+		csum_cmd |= TxTCPCS_C;

CHECK:CAMELCASE: Avoid CamelCase: <TxIPV6F_C>
#538: FILE: drivers/net/r8169/r8169_rxtx.c:1087:
+			csum_cmd |= TxIPV6F_C;

CHECK:CAMELCASE: Avoid CamelCase: <DescOwn>
#631: FILE: drivers/net/r8169/r8169_rxtx.c:1180:
+	opts[0] = DescOwn;

CHECK:CAMELCASE: Avoid CamelCase: <FirstFrag>
#663: FILE: drivers/net/r8169/r8169_rxtx.c:1212:
+			opts1 |= FirstFrag;

CHECK:CAMELCASE: Avoid CamelCase: <LastFrag>
#665: FILE: drivers/net/r8169/r8169_rxtx.c:1214:
+			opts1 |= LastFrag;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppTxNoCloseVer>
#703: FILE: drivers/net/r8169/r8169_rxtx.c:1252:
+	switch (hw->HwSuppTxNoCloseVer) {

CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#729: FILE: drivers/net/r8169/r8169_rxtx.c:1278:
+	const uint8_t enable_tx_no_close = hw->EnableTxNoClose;

CHECK:CAMELCASE: Avoid CamelCase: <MaxTxDescPtrMask>
#743: FILE: drivers/net/r8169/r8169_rxtx.c:1292:
+						   hw->BeginHwDesCloPtr0, hw->MaxTxDescPtrMask);

total: 0 errors, 0 warnings, 21 checks, 808 lines checked
Warning in drivers/net/r8169/r8169_rxtx.c:
Using rte_smp_[r/w]mb