|WARNING| pw145938 [PATCH v1 08/18] net/r8169: add support for phy configuration

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/145938

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <HwSuppCheckPhyDisableModeVer>
#124: FILE: drivers/net/r8169/r8169_ethdev.h:42:
+	u8  HwSuppCheckPhyDisableModeVer;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#129: FILE: drivers/net/r8169/r8169_ethdev.h:47:
+	u32 HwSuppMaxPhyLinkSpeed;

CHECK:CAMELCASE: Avoid CamelCase: <PhyState>
#183: FILE: drivers/net/r8169/r8169_phy.c:375:
+rtl_wait_phy_ups_resume(struct rtl_hw *hw, u16 PhyState)

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#282: FILE: drivers/net/r8169/r8169_phy.c:474:
+	               ~(ADVERTISE_10HALF | ADVERTISE_10FULL | ADVERTISE_100HALF | ADVERTISE_100FULL));

ERROR:CODE_INDENT: code indent should use tabs where possible
#282: FILE: drivers/net/r8169/r8169_phy.c:474:
+^I               ~(ADVERTISE_10HALF | ADVERTISE_10FULL | ADVERTISE_100HALF | ADVERTISE_100FULL));$

ERROR:CODE_INDENT: code indent should use tabs where possible
#284: FILE: drivers/net/r8169/r8169_phy.c:476:
+^I               ~(ADVERTISE_1000HALF | ADVERTISE_1000FULL));$

ERROR:CODE_INDENT: code indent should use tabs where possible
#286: FILE: drivers/net/r8169/r8169_phy.c:478:
+^I                              0xA5D4) & ~(RTK_ADVERTISE_2500FULL | RTK_ADVERTISE_5000FULL));$

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#308: FILE: drivers/net/r8169/r8169_phy.c:500:
+			PMD_INIT_LOG(NOTICE, "PHY watch dog not clear, value = 0x%x", phy_reg_value);

ERROR:CODE_INDENT: code indent should use tabs where possible
#315: FILE: drivers/net/r8169/r8169_phy.c:507:
+^I^I                                  (BIT_10 | BIT_9 | BIT_8));$

CHECK:BRACES: braces {} should be used on all arms of this statement
#343: FILE: drivers/net/r8169/r8169_phy.c:535:
+	if (hw->hw_ram_code_ver == hw->sw_ram_code_ver) {
[...]
+	} else
[...]

CHECK:CAMELCASE: Avoid CamelCase: <HwHasWrRamCodeToMicroP>
#345: FILE: drivers/net/r8169/r8169_phy.c:537:
+		hw->HwHasWrRamCodeToMicroP = TRUE;

CHECK:BRACES: Unbalanced braces around else statement
#346: FILE: drivers/net/r8169/r8169_phy.c:538:
+	} else

CHECK:CAMELCASE: Avoid CamelCase: <NotWrRamCodeToMicroP>
#392: FILE: drivers/net/r8169/r8169_phy.c:584:
+	if (hw->NotWrRamCodeToMicroP == TRUE)

CHECK:BOOL_COMPARISON: Using comparison to TRUE is error prone
#392: FILE: drivers/net/r8169/r8169_phy.c:584:
+	if (hw->NotWrRamCodeToMicroP == TRUE)

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#429: FILE: drivers/net/r8169/r8169_phy.c:621:
+			udelay(100);

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#600: FILE: drivers/net/r8169/r8169_phy.h:23:
+#define MII_LPA ^I^I0x05^I/* Link partner ability reg    */$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#610: FILE: drivers/net/r8169/r8169_phy.h:33:
+#define MII_RERRCOUNTER ^I0x15^I/* Receive error counter       */$

WARNING:TYPO_SPELLING: 'asymetric' may be misspelled - perhaps 'asymmetric'?
#663: FILE: drivers/net/r8169/r8169_phy.h:86:
+#define ADVERTISE_PAUSE_ASYM	0x0800	/* Try for asymetric pause     */

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#666: FILE: drivers/net/r8169/r8169_phy.h:89:
+#define ADVERTISE_LPACK ^I0x4000^I/* Ack link partners response  */$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#667: FILE: drivers/net/r8169/r8169_phy.h:90:
+#define ADVERTISE_NPAGE ^I0x8000^I/* Next page bit               */$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#675: FILE: drivers/net/r8169/r8169_phy.h:98:
+#define RTK_ADVERTISE_10000FULL ^I0x1000$

total: 4 errors, 8 warnings, 9 checks, 599 lines checked