|WARNING| pw146135 [PATCH v2 13/18] net/r8169: implement device statistics

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/146135

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

WARNING:TYPO_SPELLING: 'underun' may be misspelled - perhaps 'underrun'?
#97: FILE: drivers/net/r8169/r8169_base.h:39:
+	u16 tx_underun;

ERROR:CODE_INDENT: code indent should use tabs where possible
#113: FILE: drivers/net/r8169/r8169_ethdev.c:44:
+                             struct rte_eth_stats *rte_stats);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#113: FILE: drivers/net/r8169/r8169_ethdev.c:44:
+                             struct rte_eth_stats *rte_stats);$

CHECK:CAMELCASE: Avoid CamelCase: <CounterAddrHigh>
#226: FILE: drivers/net/r8169/r8169_hw.c:1519:
+	RTL_W32(hw, CounterAddrHigh, (u64)paddr >> 32);

CHECK:CAMELCASE: Avoid CamelCase: <CounterAddrLow>
#228: FILE: drivers/net/r8169/r8169_hw.c:1521:
+	RTL_W32(hw, CounterAddrLow, cmd);

CHECK:CAMELCASE: Avoid CamelCase: <CounterDump>
#229: FILE: drivers/net/r8169/r8169_hw.c:1522:
+	RTL_W32(hw, CounterAddrLow, cmd | CounterDump);

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#233: FILE: drivers/net/r8169/r8169_hw.c:1526:
+		udelay(10);

ERROR:CODE_INDENT: code indent should use tabs where possible
#259: FILE: drivers/net/r8169/r8169_hw.c:1552:
+^I        ((u64)hw->tally_paddr & (DMA_BIT_MASK(32))) | CounterReset);$

CHECK:CAMELCASE: Avoid CamelCase: <CounterReset>
#259: FILE: drivers/net/r8169/r8169_hw.c:1552:
+	        ((u64)hw->tally_paddr & (DMA_BIT_MASK(32))) | CounterReset);

ERROR:CODE_INDENT: code indent should use tabs where possible
#270: FILE: drivers/net/r8169/r8169_hw.c:1563:
+^I                              sizeof(struct rtl_counters), 64, rte_socket_id());$

total: 3 errors, 3 warnings, 5 checks, 205 lines checked