|WARNING| pw143785 [PATCH 11/11] drivers: use per line logging in helpers

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Sep 7 16:57:55 CEST 2024


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/143785

_coding style issues_


WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#734: FILE: drivers/common/cnxk/roc_platform.h:279:
+#define RTE_LOGTYPE_tim cnxk_logtype_tim

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#734: FILE: drivers/common/cnxk/roc_platform.h:279:
+#define RTE_LOGTYPE_tim cnxk_logtype_tim

ERROR:SPACING: space required after that ',' (ctx:VxB)
#855: FILE: drivers/common/idpf/idpf_common_logs.h:17:
+			RTE_FMT_HEAD(__VA_ARGS__,),		\
 			                        ^

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects?
#1943: FILE: drivers/net/bnx2x/bnx2x_logs.h:21:
+#define PMD_DRV_LOG(level, sc, fmt, args...) \
+	RTE_LOG_LINE(level, BNX2X_DRIVER, \
 		"[%s:%d(%s)] " fmt,	__func__, __LINE__, \
 		(sc)->devinfo.name ? (sc)->devinfo.name : "", ## args)

ERROR:SPACING: space required after that ',' (ctx:VxB)
#2056: FILE: drivers/net/cpfl/cpfl_logs.h:18:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#2066: FILE: drivers/net/cpfl/cpfl_logs.h:25:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#2132: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:402:
+		"fd_off=%d fd =%" PRIx64 ", meta = %d  bpid =%d, len=%d",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#2537: FILE: drivers/net/hinic/base/hinic_compat.h:91:
+		HINIC_DRIVER_NAME": " fmt, ##args)

ERROR:SPACING: space required after that ',' (ctx:VxB)
#2767: FILE: drivers/net/idpf/idpf_logs.h:18:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#2778: FILE: drivers/net/idpf/idpf_logs.h:25:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#2953: FILE: drivers/net/mlx4/mlx4_utils.h:51:
+		RTE_FMT("%s:%u: %s(): " RTE_FMT_HEAD(__VA_ARGS__,), \
 		                                                ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#2965: FILE: drivers/net/mlx4/mlx4_utils.h:69:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#3375: FILE: drivers/net/octeon_ep/otx_ep_rxtx.c:921:
+				    "last_pkt_count %" PRIu64 "new_pkts %d.",

ERROR:SPACING: space required after that ',' (ctx:VxB)
#3628: FILE: drivers/net/vdev_netvsc/vdev_netvsc.c:57:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

total: 8 errors, 2 warnings, 2942 lines checked


More information about the test-report mailing list