|WARNING| pw144406 [PATCH] net/r8169: add phy registers access routines

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/144406

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

CHECK:CAMELCASE: Avoid CamelCase: <RegNum>
#93: FILE: drivers/net/r8169/r8169_phy.c:43:
+rtl_map_phy_ocp_addr(u16 PageNum, u8 RegNum)

CHECK:BRACES: braces {} should be used on all arms of this statement
#109: FILE: drivers/net/r8169/r8169_phy.c:59:
+	if (ocp_reg_num < 16)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#111: FILE: drivers/net/r8169/r8169_phy.c:61:
+	else {

CHECK:CAMELCASE: Avoid CamelCase: <RegAddr>
#122: FILE: drivers/net/r8169/r8169_phy.c:72:
+rtl_mdio_real_read_phy_ocp(struct rtl_hw *hw, u32 RegAddr)

CHECK:CAMELCASE: Avoid CamelCase: <OCPR_Addr_Reg_shift>
#128: FILE: drivers/net/r8169/r8169_phy.c:78:
+	data32 <<= OCPR_Addr_Reg_shift;

CHECK:CAMELCASE: Avoid CamelCase: <OCPR_Flag>
#134: FILE: drivers/net/r8169/r8169_phy.c:84:
+		if (RTL_R32(hw, PHYOCP) & OCPR_Flag)

CHECK:CAMELCASE: Avoid CamelCase: <OCPDR_Data_Mask>
#137: FILE: drivers/net/r8169/r8169_phy.c:87:
+	value = RTL_R32(hw, PHYOCP) & OCPDR_Data_Mask;

CHECK:CAMELCASE: Avoid CamelCase: <OCPR_Write>
#172: FILE: drivers/net/r8169/r8169_phy.c:122:
+	data32 |= OCPR_Write | value;

ERROR:CODE_INDENT: code indent should use tabs where possible
#221: FILE: drivers/net/r8169/r8169_phy.c:171:
+                                  u16 setmask)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#221: FILE: drivers/net/r8169/r8169_phy.c:171:
+                                  u16 setmask)$

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Write>
#248: FILE: drivers/net/r8169/r8169_phy.c:198:
+	RTL_W32(hw, EPHYAR, EPHYAR_Write |

ERROR:CODE_INDENT: code indent should use tabs where possible
#249: FILE: drivers/net/r8169/r8169_phy.c:199:
+^I        (addr & EPHYAR_Reg_Mask_v2) << EPHYAR_Reg_shift |$

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Reg_Mask_v2>
#249: FILE: drivers/net/r8169/r8169_phy.c:199:
+	        (addr & EPHYAR_Reg_Mask_v2) << EPHYAR_Reg_shift |

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Reg_shift>
#249: FILE: drivers/net/r8169/r8169_phy.c:199:
+	        (addr & EPHYAR_Reg_Mask_v2) << EPHYAR_Reg_shift |

ERROR:CODE_INDENT: code indent should use tabs where possible
#250: FILE: drivers/net/r8169/r8169_phy.c:200:
+^I        (value & EPHYAR_Data_Mask));$

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Data_Mask>
#250: FILE: drivers/net/r8169/r8169_phy.c:200:
+	        (value & EPHYAR_Data_Mask));

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#253: FILE: drivers/net/r8169/r8169_phy.c:203:
+		udelay(100);

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Flag>
#256: FILE: drivers/net/r8169/r8169_phy.c:206:
+		if (!(RTL_R32(hw, EPHYAR) & EPHYAR_Flag))

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#260: FILE: drivers/net/r8169/r8169_phy.c:210:
+	udelay(20);

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Read>
#269: FILE: drivers/net/r8169/r8169_phy.c:219:
+	RTL_W32(hw, EPHYAR, EPHYAR_Read | (addr & EPHYAR_Reg_Mask_v2) <<

ERROR:CODE_INDENT: code indent should use tabs where possible
#270: FILE: drivers/net/r8169/r8169_phy.c:220:
+^I        EPHYAR_Reg_shift);$

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#273: FILE: drivers/net/r8169/r8169_phy.c:223:
+		udelay(100);

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#282: FILE: drivers/net/r8169/r8169_phy.c:232:
+	udelay(20);

ERROR:CODE_INDENT: code indent should use tabs where possible
#289: FILE: drivers/net/r8169/r8169_phy.c:239:
+                               u16 setmask)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#289: FILE: drivers/net/r8169/r8169_phy.c:239:
+                               u16 setmask)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#326: FILE: drivers/net/r8169/r8169_phy.h:27:
+                                       u16 clearmask, u16 setmask);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#326: FILE: drivers/net/r8169/r8169_phy.h:27:
+                                       u16 clearmask, u16 setmask);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#333: FILE: drivers/net/r8169/r8169_phy.h:34:
+                                    u16 setmask);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#333: FILE: drivers/net/r8169/r8169_phy.h:34:
+                                    u16 setmask);$

total: 7 errors, 5 warnings, 18 checks, 252 lines checked