|SUCCESS| pw159228 [PATCH v5 17/17] lib: enable format overflow warnings

[0-day Robot]

Test-Label: 0day Robot - Claude SONNET
Test-Status: SUCCESS
http://dpdk.org/patch/159228

_AI Review Comments Available_

Looking at this commit, I have a concern about enabling format overflow
warnings without addressing the underlying issues that these warnings were
suppressing.

git sha: [Need to call commit function to get exact sha]
Author: Stephen Hemminger <stephen at networkplumber.org>
lib: enable format overflow warnings

Enable compiler checking of format overflow

> diff --git a/lib/meson.build b/lib/meson.build
> index c8f4270868..8f5cfd28a5 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -113,10 +113,6 @@ default_cflags = machine_args
>  default_cflags += ['-DALLOW_EXPERIMENTAL_API']
>  default_cflags += ['-DALLOW_INTERNAL_API']
>  
> -if cc.has_argument('-Wno-format-truncation')
> -    default_cflags += '-Wno-format-truncation'
> -endif
> -

Will this change introduce build failures on existing code? The original
warning suppression was likely added because there were legitimate
format truncation cases in the codebase that would cause compilation
errors when treated as warnings or errors.

Has all existing code been audited to ensure no format truncation warnings
exist? Without seeing the fixes to address the underlying issues that this
warning flag was suppressing, this change could break builds for
developers and CI systems.

Should this change be part of a series that first fixes all format
truncation issues, then removes the warning suppression? The commit
message suggests this enables "format overflow" checking, but the code
removes suppression for "format-truncation" warnings.