|WARNING| pw159530 [PATCH 7/9] net/sfc: rework the capability check that is done on FEC set

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Dec 29 22:36:36 CET 2025


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/159530

_coding style issues_


WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#155: FILE: drivers/net/sfc/sfc_ethdev.c:2750:
+			return 0;
+		} else {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#167: FILE: drivers/net/sfc/sfc_ethdev.c:2762:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#215: FILE: drivers/net/sfc/sfc_ethdev.c:2790:
+			return ENOTSUP;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#225: FILE: drivers/net/sfc/sfc_ethdev.c:2796:
+			return ENOTSUP;

total: 0 errors, 4 warnings, 0 checks, 137 lines checked


More information about the test-report mailing list