|WARNING| pw150864 [PATCH] net: support Arista L2 headers

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/150864

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#166: FILE: lib/net/rte_ether.h:66:
+#define RTE_AVSP_SUBTYPE_TGEN            0xCAFE

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#167: FILE: lib/net/rte_ether.h:67:
+#define RTE_AVSP_VERSION_TGEN            0x0001

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#168: FILE: lib/net/rte_ether.h:68:
+#define RTE_AVSP_SUBTYPE_TIMESTAMP 0x0001

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#169: FILE: lib/net/rte_ether.h:69:
+#define RTE_AVSP_VERSION_64_MASK   0x0010

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#170: FILE: lib/net/rte_ether.h:70:
+#define RTE_AVSP_VERSION_48_MASK   0x0020

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#224: FILE: lib/net/rte_net.c:273:
+     if (proto == rte_cpu_to_be_16(RTE_ETHER_TYPE_AVSP)) {
+           union {

WARNING:LONG_LINE: line length of 177 exceeds 100 columns
#239: FILE: lib/net/rte_net.c:288:
+                                                      &ah_copy.common);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#240: FILE: lib/net/rte_net.c:289:
+           if (unlikely(ah.common == NULL))
+                 return pkt_type;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#245: FILE: lib/net/rte_net.c:294:
+           if (subtype == RTE_AVSP_SUBTYPE_TGEN &&
[...]
+                 ah.tgen = rte_pktmbuf_read(m, off, sizeof(*ah.tgen), &ah_copy);

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#246: FILE: lib/net/rte_net.c:295:
+                       (version == RTE_AVSP_VERSION_TGEN)) {

WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#247: FILE: lib/net/rte_net.c:296:
+                 ah.tgen = rte_pktmbuf_read(m, off, sizeof(*ah.tgen), &ah_copy);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#248: FILE: lib/net/rte_net.c:297:
+                 if (unlikely(ah.tgen == NULL))
+                       return pkt_type;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#253: FILE: lib/net/rte_net.c:302:
+           } else if ((subtype == RTE_AVSP_SUBTYPE_TIMESTAMP &&
[...]
+                 ah.t64 = rte_pktmbuf_read(m, off, sizeof(*ah.t64), &ah_copy);

WARNING:LONG_LINE: line length of 132 exceeds 100 columns
#254: FILE: lib/net/rte_net.c:303:
+                             (version & RTE_AVSP_VERSION_64_MASK) != 0)) {

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#255: FILE: lib/net/rte_net.c:304:
+                 ah.t64 = rte_pktmbuf_read(m, off, sizeof(*ah.t64), &ah_copy);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#256: FILE: lib/net/rte_net.c:305:
+                 if (unlikely(ah.t64 == NULL))
+                       return pkt_type;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#261: FILE: lib/net/rte_net.c:310:
+           } else if ((subtype == RTE_AVSP_SUBTYPE_TIMESTAMP &&
[...]
+                 ah.t48 = rte_pktmbuf_read(m, off, sizeof(*ah.t48), &ah_copy);

WARNING:LONG_LINE: line length of 132 exceeds 100 columns
#262: FILE: lib/net/rte_net.c:311:
+                             (version & RTE_AVSP_VERSION_48_MASK) != 0)) {

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#263: FILE: lib/net/rte_net.c:312:
+                 ah.t48 = rte_pktmbuf_read(m, off, sizeof(*ah.t48), &ah_copy);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#264: FILE: lib/net/rte_net.c:313:
+                 if (unlikely(ah.t48 == NULL))
+                       return pkt_type;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#269: FILE: lib/net/rte_net.c:318:
+           } else
+                 return pkt_type;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#272: FILE: lib/net/rte_net.c:321:
+     if ((proto == rte_cpu_to_be_16(RTE_ETHER_TYPE_MPLS)) ||
[...]
            unsigned int i;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#280: FILE: lib/net/rte_net.c:473:
+     if (proto == rte_cpu_to_be_16(RTE_ETHER_TYPE_AVSP)) {
+           union {

WARNING:LONG_LINE: line length of 177 exceeds 100 columns
#295: FILE: lib/net/rte_net.c:488:
+                                                      &ah_copy.common);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#296: FILE: lib/net/rte_net.c:489:
+           if (unlikely(ah.common == NULL))
+                 return pkt_type;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#301: FILE: lib/net/rte_net.c:494:
+           if (subtype == RTE_AVSP_SUBTYPE_TGEN &&
[...]
+                 ah.tgen = rte_pktmbuf_read(m, off, sizeof(*ah.tgen), &ah_copy);

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#302: FILE: lib/net/rte_net.c:495:
+                       (version == RTE_AVSP_VERSION_TGEN)) {

WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#303: FILE: lib/net/rte_net.c:496:
+                 ah.tgen = rte_pktmbuf_read(m, off, sizeof(*ah.tgen), &ah_copy);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#304: FILE: lib/net/rte_net.c:497:
+                 if (unlikely(ah.tgen == NULL))
+                       return pkt_type;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#309: FILE: lib/net/rte_net.c:502:
+           } else if ((subtype == RTE_AVSP_SUBTYPE_TIMESTAMP &&
[...]
+                 ah.t64 = rte_pktmbuf_read(m, off, sizeof(*ah.t64), &ah_copy);

WARNING:LONG_LINE: line length of 132 exceeds 100 columns
#310: FILE: lib/net/rte_net.c:503:
+                             (version & RTE_AVSP_VERSION_64_MASK) != 0)) {

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#311: FILE: lib/net/rte_net.c:504:
+                 ah.t64 = rte_pktmbuf_read(m, off, sizeof(*ah.t64), &ah_copy);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#312: FILE: lib/net/rte_net.c:505:
+                 if (unlikely(ah.t64 == NULL))
+                       return pkt_type;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#317: FILE: lib/net/rte_net.c:510:
+           } else if ((subtype == RTE_AVSP_SUBTYPE_TIMESTAMP &&
[...]
+                 ah.t48 = rte_pktmbuf_read(m, off, sizeof(*ah.t48), &ah_copy);

WARNING:LONG_LINE: line length of 132 exceeds 100 columns
#318: FILE: lib/net/rte_net.c:511:
+                             (version & RTE_AVSP_VERSION_48_MASK) != 0)) {

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#319: FILE: lib/net/rte_net.c:512:
+                 ah.t48 = rte_pktmbuf_read(m, off, sizeof(*ah.t48), &ah_copy);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#320: FILE: lib/net/rte_net.c:513:
+                 if (unlikely(ah.t48 == NULL))
+                       return pkt_type;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#325: FILE: lib/net/rte_net.c:518:
+           } else
+                 return pkt_type;

WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: Denis  Davidoglu <denis.davidoglu at b-ulltech.com>' != 'Signed-off-by: Denis Davidoglu <denis.davidoglu at b-ulltech.com>'

total: 5 errors, 34 warnings, 161 lines checked